492 fiware secure header does not support dynamic update#493
Merged
492 fiware secure header does not support dynamic update#493
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #492 by ensuring FIWARE headers (including dynamically computed secure tokens) are composed at request time rather than being snapshotted at client initialization.
Changes:
- Added a central
BaseHttpClient.request()helper that re-dumpsfiware_headersfor every outgoing call, and refactored HTTP verb helpers to use it. - Refactored NGSI v2 / NGSI-LD pagination helpers to route through the centralized request path.
- Added a unit test for dynamic header refresh behavior and updated the secure-header example + changelog.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
filip/clients/base_http_client.py |
Introduces per-request FIWARE header injection and routes all HTTP verbs through a shared request helper. |
filip/clients/ngsi_v2/cb.py |
Pagination now uses the shared request helper (and thus the new header injection behavior). |
filip/clients/ngsi_ld/cb.py |
Same pagination refactor as NGSI v2, via the shared request helper. |
filip/clients/ngsi_v2/iota.py |
Adjusts service/path checks to use fiware_service properties; tweaks admin log header handling. |
tests/clients/test_ngsi_v2_client.py |
Adds a regression test ensuring Authorization is recomputed per request. |
examples/ngsi_v2/e13_ngsi_v2_secure_fiware_headers.py |
Updates example to demonstrate request-time token refresh using a Keycloak-backed computed header. |
CHANGELOG.md |
Notes the dynamic header composition fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j-pick
approved these changes
Apr 22, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #492