Skip to content

39-change-contact-mail#110

Open
lwaer wants to merge 3 commits intomainfrom
39-change-contact-mail
Open

39-change-contact-mail#110
lwaer wants to merge 3 commits intomainfrom
39-change-contact-mail

Conversation

@lwaer
Copy link
Copy Markdown
Contributor

@lwaer lwaer commented Jan 13, 2026

Pull Request

Description

Changed contact mail address and updated authors according to license file

Type of Change

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code change that neither fixes a bug nor adds a feature)
  • [x ] Documentation update

Required Checklist

Testing

  • Unit tests have been created/updated for new/modified functionality
  • CI/CD pipeline passes all tests (pytest, pylint, coverage)

Examples

  • Add examples for new features and functionality

Compatibility

  • Changes are backward compatible OR deprecation warnings added
  • No breaking changes to public APIs
  • New dependencies added to pyproject.toml (required in dependencies or optional in [project.optional-dependencies])

OPTIONAL: Release Information

  • Version number updated in agentlib_mpc/__init__.py (Required for PyPI release)
    • Version: ___.___.___
  • CHANGELOG.md updated with description of changes (Required for PyPI release)

Documentation

  • Docstrings added/updated for new/modified public methods (Google style)
  • Type hints added for new functions/methods

Breaking Changes

Optional

GitHub Copilot Review

  • Request Copilot review via GitHub UI (add 'copilot' as a reviewer)

Note: PRs will not be merged without completed required checklist items and passing CI/CD pipeline.

@lwaer lwaer linked an issue Jan 13, 2026 that may be closed by this pull request
@lwaer lwaer self-assigned this Jan 13, 2026
Copy link
Copy Markdown
Contributor

@PatrickHenkel1 PatrickHenkel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only update the contact email, copyright and authors cannot be changed as Bosch is part of the project

@FelixStege
Copy link
Copy Markdown
Contributor

What we could think about is adding a maintainer field and add the EBC (and e.g. Bosch or FAU) there. Additionally, we could add these parties to the copyright with a date (e.g. 2021, AGENT-Project Associates; 2026, EBC..). However, this is something we would need to discuss with the AGENT consortium (@EserSteffen).

@lwaer
Copy link
Copy Markdown
Contributor Author

lwaer commented Feb 26, 2026

Hi Sarah,
I have updated the contact information according to the copyright, as we talked about. I

  • added a field for maintainers with our institute's credentials
  • kept the author according to copyright

It should be ready for merge now, let me know what you think!

@lwaer lwaer requested a review from sarahleidolf February 26, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change contact mail

5 participants