build: update peft requirement from <0.19.0,>=0.18.0 to >=0.18.0,<0.20.0#663
Open
dependabot[bot] wants to merge 1 commit into
Open
build: update peft requirement from <0.19.0,>=0.18.0 to >=0.18.0,<0.20.0#663dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Updates the requirements on [peft](https://github.com/huggingface/peft) to permit the latest version. - [Release notes](https://github.com/huggingface/peft/releases) - [Commits](huggingface/peft@v0.18.0...v0.19.1) --- updated-dependencies: - dependency-name: peft dependency-version: 0.19.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 227ef6d. Configure here.
| # peft 0.19+ enforces torchao>=0.16 in PEFT (is_torchao_available); keep <0.19 while core torchao stays <0.16. | ||
| # https://github.com/huggingface/peft/blob/6d5a6f4f2f902dbf13d21d2661d57c3c05df1dae/src/peft/import_utils.py#L131 | ||
| "peft>=0.18.0,<0.19.0", | ||
| "peft>=0.18.0,<0.20.0", |
There was a problem hiding this comment.
Peft bump ignores torchao cap
Medium Severity
Widening peft to <0.20.0 allows 0.19.x, which treats torchao below 0.16 as unavailable in PEFT, while dependencies still cap torchao below 0.16. The comment still says to keep peft below 0.19 for that reason but was not updated.
Reviewed by Cursor Bugbot for commit 227ef6d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on peft to permit the latest version.
Release notes
Sourced from peft's releases.
Commits
ba6a190Patch release 0.19.1 (#3168)6d5a6f4Release 0.19.0 (#3155)076214cFIX Explicit weight conversion map for Mixtral (#3146)b386d59ENH Support models with low precision float dtypes (#3055)cf9709cFIX Correct scaling with DARE merging (#3152)efe0fe6Bump the third-party-actions group with 8 updates (#3125)07a1db6ENH Checkpoint saving with Tensor Parallel (#3096)f62f54bTST Enable arrow xpu tests (#3145)9846593CI Move slow EVA tests to nightly GPU CI (#3108)12d872aFIX CI Remove invalid arg in nightly GPU test call (#3104)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)