Add Japanese localization entries for forms and abilities from the latest games#1493
Open
nikollson wants to merge 6 commits intoPokeAPI:masterfrom
Open
Add Japanese localization entries for forms and abilities from the latest games#1493nikollson wants to merge 6 commits intoPokeAPI:masterfrom
nikollson wants to merge 6 commits intoPokeAPI:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Add Japanese localization entries for Pokemon forms and abilities from the latest games.
This PR includes:
ja/ja-hrktform names for selected Mega and Gigantamax formsThe Japanese entries in this PR were checked against in-game text from Pokemon Scarlet/Violet and Pokemon Champions, as well as official Pokedex pages, for example:
How to test:
make build-dbmake testmake serve/api/v2/pokemon-form/<form>//api/v2/ability/<ability>/AI coding assistance disclosure
I used AI coding assistance to help create small helper scripts for inspecting the repository data, listing Japanese localization entries that were not yet covered for newer game content.
I manually reviewed and edited the final data changes myself, then verified the results locally with:
make build-dbmake testContributor check list