Add regional form evolution details#1492
Open
jemarq04 wants to merge 6 commits intoPokeAPI:masterfrom
Open
Conversation
…add_regional_form_evolution_details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
This PR adds evolution details regarding all regional forms (Alola, Galar, Hisui, and Paldea) including some related region-specific evolutions (e.g. Cyndaquil to Quilava at level 17 instead of 14, but only in Hisui).
This is related to issue #1396. In addition to new evolution details,
region_idandbase_form_idare renamed to beregionandbase_formto be consistent with other fields (similar to PR #1487). Thebase_formfield was changed to aPokemonmodel so that regional forms could be specified. These fields were also missing from tests, so they were added as well.An unintended consequence of this is that the latest evolution detail will not necessarily reflect the current evolution (like the Cyndaquil example I gave previously). At some point I'd like to add something to make the current evolution method clearer (maybe even accessible by version group?) but while I tinker with that these additions should be added.
Contributor check list