Skip to content

adding pokemon from champions#1491

Open
digitalghost-dev wants to merge 2 commits intoPokeAPI:masterfrom
digitalghost-dev:master
Open

adding pokemon from champions#1491
digitalghost-dev wants to merge 2 commits intoPokeAPI:masterfrom
digitalghost-dev:master

Conversation

@digitalghost-dev
Copy link
Copy Markdown
Contributor

Change description

I've added Pokémon from Champions to the respective files outlined in issue #1484.

For the pokedex_number number, I just added the Pokémon's national Pokédex number as outlined in the Serebii Pokédex. Not sure if this was correct choice, but let me know.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

Copy link
Copy Markdown
Contributor

@jemarq04 jemarq04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using the national dex numbers for these is reasonable since there's not a strict in-game pokedex. Other than the typo, this looks good!

Comment thread data/v2/csv/pokemon_dex_numbers.csv Outdated
Co-authored-by: Justin Marquez <37006684+jemarq04@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants