chore(deps): update aerospike/aerospike-server docker tag to v8#2548
chore(deps): update aerospike/aerospike-server docker tag to v8#2548
Conversation
33d3bf5 to
da21ce7
Compare
4bef447 to
e2dbbfc
Compare
ffc10a1 to
0a388d3
Compare
0a388d3 to
2ba7c4f
Compare
2ba7c4f to
3936044
Compare
3936044 to
0f90902
Compare
0f90902 to
c603052
Compare
c603052 to
f26bf39
Compare
a9a5e97 to
6d6ec22
Compare
6d6ec22 to
ba01867
Compare
ba01867 to
739e311
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe default Aerospike Docker image version was updated from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
79c4d08 to
5045c83
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@embedded-aerospike/src/main/java/com/playtika/testcontainer/aerospike/AerospikeProperties.java`:
- Line 27: The Docker image was bumped to Aerospike server 8.1.1.1 in
AerospikeProperties (the return value for the image string), but the project
still depends on aerospike-client 7.2.2 which is incompatible; update the
project's aerospike-client dependency to version 9.3.0 or later in the build
configuration (pom.xml or build.gradle) so the Java client matches Server 8.x,
then rebuild and run unit/integration tests that exercise Aerospike-related code
(classes using the Aerospike client) to verify compatibility and adjust any API
changes in client usage if tests fail.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c053cf0d-12db-47ad-8555-a983504b0999
📒 Files selected for processing (2)
embedded-aerospike/README.adocembedded-aerospike/src/main/java/com/playtika/testcontainer/aerospike/AerospikeProperties.java
| // Please don`t remove this comment. | ||
| // renovate: datasource=docker | ||
| return "aerospike/aerospike-server:7.2.0.6"; | ||
| return "aerospike/aerospike-server:8.1.1.1"; |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Aerospike server 8.x compatibility with aerospike-client 7.2.2
💡 Result:
Aerospike Server 8.x is not “fully feature compatible” with Aerospike Java client (aerospike-client) 7.2.2.
- Aerospike’s Client Matrix lists the minimum Java client for full compatibility with Server 8.x as:
- Server 8.0.0 → Java client 9.0.3+
- Server 8.1.0 → Java client 9.1.0+
- Server 8.1.1 → Java client 9.3.0+ [1]
aerospike-client7.2.2 is an older Java client release (June 28, 2024). [2]
What this means in practice:
- 7.2.2 will typically still connect and perform basic operations against an upgraded cluster, as long as you don’t use features/protocol behavior that changed/deprecated/removed—but you should not expect support for Server 8.x features and you’re outside the “full compatibility” guidance. [1]
- If you’re running Server 8.x in production, you should plan to upgrade the Java client to 9.x (matching the server minor as above). [1]
Sources:
[1] Aerospike “Client Matrix” compatibility table and guidance. (aerospike.com)
[2] Aerospike Java client downloads page showing version 7.2.2. (download.aerospike.com)
Citations:
- 1: https://aerospike.com/docs/develop/client-matrix/
- 2: https://download.aerospike.com/download/client/java/releases.html?utm_source=openai
🏁 Script executed:
#!/bin/bash
# Check Docker Hub for the specific Aerospike image tag
curl -s "https://registry.hub.docker.com/v2/repositories/library/aerospike/tags/?page_size=100&name=8.1.1.1" 2>/dev/null | jq -r '.results[].name' 2>/dev/null || echo "Docker Hub API call failed or image tag not found"
# Alternative check using Docker Hub REST API
curl -s "https://hub.docker.com/v2/repositories/aerospike/aerospike-server/tags/?page_size=50" 2>/dev/null | jq '.results[] | select(.name | contains("8.1.1")) | .name' 2>/dev/null || echo "No matching tags found"Repository: PlaytikaOSS/testcontainers-spring-boot
Length of output: 173
Upgrade aerospike-client to version 9.3.0 or later before using Aerospike server 8.1.1.
This bump updates the Docker image from Aerospike 7.2.0.6 to 8.1.1.1—a major version upgrade. The project currently uses aerospike-client 7.2.2, which is incompatible with Server 8.1.1. Per Aerospike's official client compatibility matrix, Server 8.1.1 requires Java client 9.3.0 or higher for full compatibility. While version 7.2.2 may perform basic operations, it is outside the supported compatibility guidance and lacks support for Server 8.x features.
Update aerospike-client to 9.3.0+ in the project dependencies before this change takes effect.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@embedded-aerospike/src/main/java/com/playtika/testcontainer/aerospike/AerospikeProperties.java`
at line 27, The Docker image was bumped to Aerospike server 8.1.1.1 in
AerospikeProperties (the return value for the image string), but the project
still depends on aerospike-client 7.2.2 which is incompatible; update the
project's aerospike-client dependency to version 9.3.0 or later in the build
configuration (pom.xml or build.gradle) so the Java client matches Server 8.x,
then rebuild and run unit/integration tests that exercise Aerospike-related code
(classes using the Aerospike client) to verify compatibility and adjust any API
changes in client usage if tests fail.
5045c83 to
8e9db7c
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
embedded-aerospike/src/main/java/com/playtika/testcontainer/aerospike/AerospikeProperties.java (1)
27-27:⚠️ Potential issue | 🟠 MajorVerify client/server version alignment before merging.
Line 27 bumps the container to
aerospike/aerospike-server:8.1.1.1, while repo context still showsaerospike-client7.2.3. Please align the Java client with the Server 8.x compatibility matrix (or pin server back) to avoid unsupported behavior at runtime.#!/bin/bash # Read-only verification: locate Aerospike client dependency declarations. fd -HI 'pom.xml|build.gradle|build.gradle.kts' | xargs -r rg -n -C2 'aerospike-client|com\.aerospike'Aerospike client matrix minimum Java client version for Aerospike Server 8.1.1🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@embedded-aerospike/src/main/java/com/playtika/testcontainer/aerospike/AerospikeProperties.java` at line 27, The Docker image version in AerospikeProperties (the method returning "aerospike/aerospike-server:8.1.1.1") is out of sync with the Java client version in the repo; either change the image back to a server tag compatible with the current aerospike-client (e.g., the 7.x server image) or bump the Java client dependency to an 8.x client that supports Server 8.1.1.1. Locate the string return in AerospikeProperties (the method that returns the image name) and update it to a server version that matches the existing client, or update the project's pom.xml/build.gradle to the appropriate aerospike-client 8.x version per Aerospike’s compatibility matrix and run the provided grep/fd check to verify all client declarations were changed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In
`@embedded-aerospike/src/main/java/com/playtika/testcontainer/aerospike/AerospikeProperties.java`:
- Line 27: The Docker image version in AerospikeProperties (the method returning
"aerospike/aerospike-server:8.1.1.1") is out of sync with the Java client
version in the repo; either change the image back to a server tag compatible
with the current aerospike-client (e.g., the 7.x server image) or bump the Java
client dependency to an 8.x client that supports Server 8.1.1.1. Locate the
string return in AerospikeProperties (the method that returns the image name)
and update it to a server version that matches the existing client, or update
the project's pom.xml/build.gradle to the appropriate aerospike-client 8.x
version per Aerospike’s compatibility matrix and run the provided grep/fd check
to verify all client declarations were changed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 309bfe61-d047-475b-b916-20786a9ba38c
📒 Files selected for processing (2)
embedded-aerospike/README.adocembedded-aerospike/src/main/java/com/playtika/testcontainer/aerospike/AerospikeProperties.java
🚧 Files skipped from review as they are similar to previous changes (1)
- embedded-aerospike/README.adoc
d039503 to
6431290
Compare
6431290 to
6de2c8c
Compare
6de2c8c to
c3cfb65
Compare
| datasource | package | from | to | | ---------- | -------------------------- | ------- | ------- | | docker | aerospike/aerospike-server | 7.2.0.6 | 8.1.2.0 |
c3cfb65 to
9964fb3
Compare
This PR contains the following updates:
7.2.0.6->8.1.0.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.
Summary by CodeRabbit