Introduce TestNG to JUnit migration module [DRAFT]#507
Draft
Introduce TestNG to JUnit migration module [DRAFT]#507
Conversation
rickie
changed the title
rickie
changed the title
rickie
changed the title
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
rickie
reviewed
Feb 23, 2023
rickie
reviewed
Feb 23, 2023
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
2 similar comments
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
1 similar comment
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
rickie
force-pushed
the
gdejong/testng-migrator
branch
from
0dadcce to
405b917
Compare
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
1 similar comment
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
1 similar comment
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
rickie
reviewed
Mar 20, 2023
|
|
||
| # Use the Maven Wrapper executable if present. | ||
| MVN='mvn' | ||
| if [ -x ./mvnw ]; then |
Member
There was a problem hiding this comment.
We don't need to do this. We have this internally but there is a thread where someone mentioned it is not best practice.
| echo "Number of JUnit tests run: $junit_results" | ||
| echo "Difference: $(expr ${testng_results} - ${junit_results})" | ||
|
|
||
| echo "Finished migration steps!" |
Member
There was a problem hiding this comment.
Will add a few tweaks to the script and strings :).
| import org.junit.jupiter.api.Test; | ||
|
|
||
| // Should be de-duplicated in the future, for example by depending on `error-prone-contrib` | ||
| final class SourceCodeTest { |
Member
There was a problem hiding this comment.
Hmm, we discussed this offline a few times. Let's drop it because it tests something we do not really use.
|
|
||
| final class TestNGMatchersTest { | ||
| @Test | ||
| void nGAnnotation() { |
Member
There was a problem hiding this comment.
There is some overlap here, we can combine the tests :). Will push a proposal.
This reverts commit 37580fa.
…ovider migrations
rickie
force-pushed
the
gdejong/testng-migrator
branch
from
561adcd to
fdf6813
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return Optional.of( | ||
| SuggestedFix.builder() | ||
| .addImport("org.junit.jupiter.params.ParameterizedTest") | ||
| .addImport("org.junit.jupiter.params.provider.MethodSource") |
There was a problem hiding this comment.
[javac] reported by reviewdog 🐶
[UnqualifiedSuggestedFixImport] Prefer SuggestedFixes#qualifyType over direct invocation of SuggestedFix.Builder#addImport
|
|
||
| return Optional.of( | ||
| SuggestedFix.builder() | ||
| .addImport("org.junit.jupiter.params.ParameterizedTest") |
There was a problem hiding this comment.
[javac] reported by reviewdog 🐶
[UnqualifiedSuggestedFixImport] Prefer SuggestedFixes#qualifyType over direct invocation of SuggestedFix.Builder#addImport
| SuggestedFix.builder() | ||
| .addStaticImport("org.junit.jupiter.params.provider.Arguments.arguments") | ||
| .addImport(Stream.class.getCanonicalName()) | ||
| .addImport("org.junit.jupiter.params.provider.Arguments") |
There was a problem hiding this comment.
[javac] reported by reviewdog 🐶
[UnqualifiedSuggestedFixImport] Prefer SuggestedFixes#qualifyType over direct invocation of SuggestedFix.Builder#addImport
| dataProviderReturnTree -> | ||
| SuggestedFix.builder() | ||
| .addStaticImport("org.junit.jupiter.params.provider.Arguments.arguments") | ||
| .addImport(Stream.class.getCanonicalName()) |
There was a problem hiding this comment.
[javac] reported by reviewdog 🐶
[UnqualifiedSuggestedFixImport] Prefer SuggestedFixes#qualifyType over direct invocation of SuggestedFix.Builder#addImport
| .map( | ||
| dataProviderReturnTree -> | ||
| SuggestedFix.builder() | ||
| .addStaticImport("org.junit.jupiter.params.provider.Arguments.arguments") |
There was a problem hiding this comment.
[javac] reported by reviewdog 🐶
[UnqualifiedSuggestedFixImport] Prefer SuggestedFixes#qualifyStaticImport over direct invocation of SuggestedFix.Builder#addStaticImport
| SuggestedFix.builder() | ||
| .addImport("org.junit.jupiter.api.Order") | ||
| .addImport("org.junit.jupiter.api.TestMethodOrder") | ||
| .addImport("org.junit.jupiter.api.MethodOrderer") |
There was a problem hiding this comment.
[javac] reported by reviewdog 🐶
[UnqualifiedSuggestedFixImport] Prefer SuggestedFixes#qualifyType over direct invocation of SuggestedFix.Builder#addImport
| priority -> | ||
| SuggestedFix.builder() | ||
| .addImport("org.junit.jupiter.api.Order") | ||
| .addImport("org.junit.jupiter.api.TestMethodOrder") |
There was a problem hiding this comment.
[javac] reported by reviewdog 🐶
[UnqualifiedSuggestedFixImport] Prefer SuggestedFixes#qualifyType over direct invocation of SuggestedFix.Builder#addImport
| .map( | ||
| priority -> | ||
| SuggestedFix.builder() | ||
| .addImport("org.junit.jupiter.api.Order") |
There was a problem hiding this comment.
[javac] reported by reviewdog 🐶
[UnqualifiedSuggestedFixImport] Prefer SuggestedFixes#qualifyType over direct invocation of SuggestedFix.Builder#addImport
| timeOut -> | ||
| SuggestedFix.builder() | ||
| .addImport("org.junit.jupiter.api.Timeout") | ||
| .addStaticImport(TimeUnit.class.getCanonicalName() + ".MILLISECONDS") |
There was a problem hiding this comment.
[javac] reported by reviewdog 🐶
[UnqualifiedSuggestedFixImport] Prefer SuggestedFixes#qualifyStaticImport over direct invocation of SuggestedFix.Builder#addStaticImport
| .map( | ||
| timeOut -> | ||
| SuggestedFix.builder() | ||
| .addImport("org.junit.jupiter.api.Timeout") |
There was a problem hiding this comment.
[javac] reported by reviewdog 🐶
[UnqualifiedSuggestedFixImport] Prefer SuggestedFixes#qualifyType over direct invocation of SuggestedFix.Builder#addImport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT