Fix: VisualizePose port typo in MPC pose tracking Objectives#608
Draft
griswaldbrooks wants to merge 1 commit intomainfrom
Draft
Fix: VisualizePose port typo in MPC pose tracking Objectives#608griswaldbrooks wants to merge 1 commit intomainfrom
griswaldbrooks wants to merge 1 commit intomainfrom
Conversation
The VisualizePose Action read from {stamped_pose}, but the upstream
producer writes {pose_stamped} — the two words are transposed. Both
dynamic and static MPC pose tracking with point cloud avoidance
Objectives fail at tick time with "input port 'pose' was set to
'{stamped_pose}', which was not found", causing deterministic CI
failures in lab_sim integration tests.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two
lab_simObjectives have a transposed-word typo on aVisualizePoseBehavior port: it reads{stamped_pose}but the upstream producer writes{pose_stamped}. The variable doesn't exist on the blackboard at tick time, so the Behavior fails immediately and takes the Objective with it.This is a deterministic failure that fires every CI run on
main, contributing to the brokenintegration-test-in-studio-container (humble)job.Files affected:
src/lab_sim/objectives/mpc_pose_tracking_dynamic_point_cloud_avoidance_with_sphere_down_sample.xml:27src/lab_sim/objectives/mpc_pose_tracking_static_point_cloud_avoidance_with_sphere_down_sample.xml:20In each file the producer is the line directly above (
ForEach … out="{pose_stamped}"in the dynamic case,CreatePoseStamped pose_stamped="{pose_stamped}"in the static case), so the fix is a one-token swap.Failing log signature on
main:Test plan
integration-test-in-studio-container (humble)runsMPC Pose Tracking Dynamic Point Cloud Avoidance with Sphere Down SampleandMPC Pose Tracking Static Point Cloud Avoidance with Sphere Down Sampleto SUCCESS (was failing onmain).{stamped_pose}(verified by grep — only these two files used the typo'd name).🤖 Generated with Claude Code