Skip to content

Commit 3e420a3

Browse files
committed
chore: simpler detect-changes filters
1 parent 52faf19 commit 3e420a3

1 file changed

Lines changed: 19 additions & 14 deletions

File tree

.github/workflows/verify-pr.yml

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@ jobs:
1414
pull-requests: read
1515

1616
outputs:
17-
src: ${{ steps.filter.outputs.src }}
18-
screenshots: ${{ steps.filter.outputs.screenshots }}
17+
lint: ${{ steps.filter.outputs.lint }}
18+
screen-test: ${{ steps.filter.outputs.screen-test }}
19+
unit-test: ${{ steps.filter.outputs.unit-test }}
20+
build: ${{ steps.filter.outputs.build }}
1921

2022
steps:
2123
- name: Checkout
@@ -25,23 +27,26 @@ jobs:
2527
id: filter
2628
with:
2729
filters: |
28-
src:
29-
- '**/*.{js,ts,jsx,tsx,mjs,mts,css}'
30-
- '**/src/**.json'
31-
- '**/src/**.yaml'
32-
- '**/*tsconfig.json'
33-
- '**/*package.json'
30+
lint:
31+
- '**/*.{js,ts,jsx,tsx,mjs,mts,css,json}'
3432
- 'pnpm-lock.yaml'
35-
screenshots:
33+
screen-test:
34+
- '**/*.{js,ts,jsx,tsx,mjs,mts,css,json}'
3635
- '**/__screenshots__/**'
37-
- '**/*playwright*.ts'
36+
- 'pnpm-lock.yaml'
37+
unit-test:
38+
- '**/*.{js,ts,jsx,tsx,mjs,mts,css,json}'
39+
- 'pnpm-lock.yaml'
40+
build:
41+
- '**/*.{js,ts,jsx,tsx,mjs,mts,css,json}'
42+
- 'pnpm-lock.yaml'
3843
3944
lint:
4045
name: Lint
4146
runs-on: ubuntu-latest
4247

4348
needs: detect-changes
44-
if: needs.detect-changes.outputs.src == 'true'
49+
if: needs.detect-changes.outputs.lint == 'true'
4550

4651
steps:
4752
- name: Checkout
@@ -69,7 +74,7 @@ jobs:
6974
runs-on: ubuntu-latest
7075

7176
needs: detect-changes
72-
if: needs.detect-changes.outputs.src == 'true'
77+
if: needs.detect-changes.outputs.unit-test == 'true'
7378

7479
steps:
7580
- name: Checkout
@@ -97,7 +102,7 @@ jobs:
97102
runs-on: macos-latest
98103

99104
needs: detect-changes
100-
if: needs.detect-changes.outputs.src == 'true' || needs.detect-changes.outputs.screenshots == 'true'
105+
if: needs.detect-changes.outputs.screen-test == 'true'
101106

102107
strategy:
103108
matrix:
@@ -147,7 +152,7 @@ jobs:
147152
runs-on: ubuntu-latest
148153

149154
needs: detect-changes
150-
if: needs.detect-changes.outputs.src == 'true'
155+
if: needs.detect-changes.outputs.build == 'true'
151156

152157
steps:
153158
- name: Checkout

0 commit comments

Comments
 (0)