Skip to content

Commit 52faf19

Browse files
committed
chore: build job in verify-pr
Sometimes changes might pass all linters and tests, but break in build. So I guess it's better to try and build all apps in CI before merging
1 parent f2fcc38 commit 52faf19

1 file changed

Lines changed: 29 additions & 0 deletions

File tree

.github/workflows/verify-pr.yml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,34 @@ jobs:
142142
path: ${{ matrix.package }}/playwright-report/
143143
retention-days: 30
144144

145+
build:
146+
name: Build
147+
runs-on: ubuntu-latest
148+
149+
needs: detect-changes
150+
if: needs.detect-changes.outputs.src == 'true'
151+
152+
steps:
153+
- name: Checkout
154+
uses: actions/checkout@v4
155+
156+
- name: Install pnpm
157+
uses: pnpm/action-setup@v4
158+
with:
159+
run_install: false
160+
161+
- name: Install Node.js
162+
uses: actions/setup-node@v4
163+
with:
164+
node-version-file: .nvmrc
165+
cache: pnpm
166+
167+
- name: Install dependencies
168+
run: pnpm install
169+
170+
- name: Build
171+
run: pnpm exec turbo build
172+
145173
verify-pr:
146174
name: Verify PR
147175
runs-on: ubuntu-latest
@@ -151,6 +179,7 @@ jobs:
151179
- lint
152180
- unit-test
153181
- screen-test
182+
- build
154183

155184
steps:
156185
- name: Check completed jobs

0 commit comments

Comments
 (0)