Feature/config destination#9
Merged
andrew-welker merged 36 commits intomainfrom Apr 10, 2025
Merged
Conversation
…xAsText method for hex string conversion
…nd update PowerOnInputX to accept address parameter
… and send as UTF-8 text
…nitialize communication monitor
… clean up unused constants
… AddressGet to init
Contributor
There was a problem hiding this comment.
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/SoundBar/CecSoundBarDriver.cs:26
- [nitpick] The variable 'physicalAddressSetinConfig' is unclear; consider renaming it to 'isPhysicalAddressSetInConfig' for improved readability.
private bool physicalAddressSetinConfig = false;
src/SoundBar/CecSoundBarConfigObject.cs:18
- Consider renaming 'physicalAddress' to 'PhysicalAddress' to align with C# naming conventions.
public List<string> physicalAddress { get; set; }
andrew-welker
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.