Skip to content

ci: run tests on PRs to any branch, scope push trigger to dev/release#3048

Merged
ma-sadeghi merged 1 commit intodevfrom
ci/run-tests-on-dev-prs
Apr 28, 2026
Merged

ci: run tests on PRs to any branch, scope push trigger to dev/release#3048
ma-sadeghi merged 1 commit intodevfrom
ci/run-tests-on-dev-prs

Conversation

@ma-sadeghi
Copy link
Copy Markdown
Member

@ma-sadeghi ma-sadeghi commented Apr 28, 2026

Summary

  • The Tests workflow currently only runs on PRs targeting release, so PRs into dev (including external PRs like Update numpy version constraint in pyproject.toml #3047) skip the full 3 Python × 3 OS matrix.
  • Naively adding dev to the pull_request filter would double-fire CI for internal devs (push event + pull_request event on the same commits).
  • Scope push: to just dev and release (long-lived branches), and let pull_request: handle every PR. Net: PRs into dev get the matrix, no duplicate runs on feature branches.

Behavior after this change

  • Internal feature branch push → no CI yet
  • Open PR (any base) → pull_request: runs the matrix once
  • PR merges into dev or releasepush: runs the matrix once
  • External PR → pull_request: runs once

Test plan

  • Confirm this PR itself triggers exactly one Tests matrix run via pull_request:
  • After merge, confirm the push to dev triggers exactly one matrix run
  • Confirm a follow-up push to a feature branch in PMEAL/OpenPNM does not trigger CI until a PR is opened

@ma-sadeghi ma-sadeghi merged commit 91dfb20 into dev Apr 28, 2026
11 checks passed
@ma-sadeghi ma-sadeghi deleted the ci/run-tests-on-dev-prs branch April 28, 2026 11:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.7%. Comparing base (78a83c8) to head (37cd2d6).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3048   +/-   ##
=====================================
  Coverage   87.7%   87.7%           
=====================================
  Files        151     151           
  Lines       8879    8879           
=====================================
  Hits        7792    7792           
  Misses      1087    1087           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant