feat(client): added capacitor app for web by ayush-teon · Pull Request #2740 · OutlineFoundation/outline-apps

ayush-teon · 2026-04-06T18:21:14Z

No description provided.

* Capacitor App added * Updated Comments * Updated Comments * Comments addressed and updated * Splash & Icon images removed * Update README.md

* Capacitor App added * Updated Comments * Updated Comments * Comments addressed and updated * Splash & Icon images removed * Update README.md * Streamlined package.json * Actions added to capacitor * Addressed package.json review comments. * Updated build and setup * Package updated * Setup and Build files updated * Setup file updated * Build and Setup files updated * Build, Setup and Package files updated * Build, Setup and Package files updated * Gitignore, Setup and Package files updated * Setup and Gradle settings updated * Updated Readme and title --------- Co-authored-by: Zahirul Islam <[email protected]>

…lidation Nthlink/capacitor migration key validation

* UI fixes for Capacitor * UI fixes for Capacitor * Fixed Capacitor UI * Removed listeners * Event listeners updated * Update client/web/views/root_view/add_access_key_dialog/index.ts Co-authored-by: J. Yi <[email protected]> --------- Co-authored-by: J. Yi <[email protected]>

…and iOS (#7) * UI fixes for Capacitor * UI fixes for Capacitor * Fixed Capacitor UI * Removed listeners * Converted android project from Java to Kotlin * Imported OutlineAndroidLib and added Plugin for capactior * Imported OutlineAppleLib and added Plugin for capacitor * Minor Fixes * added capacitor outline plugin and web server * Fixed sidebar and root-app height issue for ios * Added capacitor outline plugin * Updated cordova and capacitor build issues * updated capacitor build for build params * updated capacitor life cycle to register plugin * Fixed status type casting for ios * updated entry point html for capacitor * Added capacitor android * es lint fixed * Updated ios build for vpn extension provisioning profile for PacketTunnel * Fixed ios splash screen and external link issue on ios and android * reverted settings.json * Added android build folder to gitignore * Added cordova outline plugin relative path to capacitor and removed capacitor plugin * Added staging build configuration for capacitor ios and android * fixed android language switch issue * revert b6a663a server manager formatting * revert b6a663a commit formatting * Added templates to resolve dependencies, added generic pluginRegisterListener method and added platform based rootPath * reverted 36e9c7b commit formatting * revert b6a663a commit formatting * added relative path for outline plugin * Mac Catalyst support added * Merge branch 'nthlink/capacitor-outline-cap-plugin', remote-tracking branch 'origin' into nthlink/capacitor-outline-debug * revert server manager changes * revert previous messages * reverted to latest merged master branch * revert outlinePlugin change in cordova plugins * Build updated * revert eslint.json * added closing body tag * removed logging tag from android main activity * added vpn extension symbolic link * updated copyright text * Bundle IDs updated * Spawn stream reverted * Updated build config for production * updated build action for android debug * added hot reloading for android and ios for development and updated page UI issues * reverted merged files * reverted UI files * added browser plugin for external link handling * App Groups bundle ID updated * removed patch package and revert lock file * added comments in AppDelegate and refactored sync files * removed ios integration * Icon added for android build * Update client/capacitor/README.md Co-authored-by: J. Yi <[email protected]> --------- Co-authored-by: Ayush Kumar Sethi <[email protected]> Co-authored-by: Hasnainhanifse <[email protected]> Co-authored-by: J. Yi <[email protected]>

) * UI fixes for Capacitor * UI fixes for Capacitor * Fixed Capacitor UI * Removed listeners * Converted android project from Java to Kotlin * Imported OutlineAndroidLib and added Plugin for capactior * Imported OutlineAppleLib and added Plugin for capacitor * Minor Fixes * added capacitor outline plugin and web server * Fixed sidebar and root-app height issue for ios * Added capacitor outline plugin * Updated cordova and capacitor build issues * updated capacitor build for build params * updated capacitor life cycle to register plugin * Fixed status type casting for ios * updated entry point html for capacitor * Added capacitor android * es lint fixed * Updated ios build for vpn extension provisioning profile for PacketTunnel * Fixed ios splash screen and external link issue on ios and android * reverted settings.json * Added android build folder to gitignore * Added cordova outline plugin relative path to capacitor and removed capacitor plugin * Added staging build configuration for capacitor ios and android * fixed android language switch issue * revert b6a663a server manager formatting * revert b6a663a commit formatting * Added templates to resolve dependencies, added generic pluginRegisterListener method and added platform based rootPath * reverted 36e9c7b commit formatting * revert b6a663a commit formatting * added relative path for outline plugin * Mac Catalyst support added * Merge branch 'nthlink/capacitor-outline-cap-plugin', remote-tracking branch 'origin' into nthlink/capacitor-outline-debug * revert server manager changes * revert previous messages * reverted to latest merged master branch * revert outlinePlugin change in cordova plugins * Build updated * revert eslint.json * added closing body tag * removed logging tag from android main activity * added vpn extension symbolic link * updated copyright text * Bundle IDs updated * Spawn stream reverted * Updated build config for production * updated build action for android debug * added hot reloading for android and ios for development and updated page UI issues * reverted merged files * reverted UI files * added browser plugin for external link handling * App Groups bundle ID updated * removed patch package and revert lock file * added comments in AppDelegate and refactored sync files * Fixed iOS removed mac config * Code Signing Updated for Capacitor iOS * Bundle ID Updated for VPN extension on Capacitor iOS --------- Co-authored-by: Hasnainhanifse <[email protected]>

* fix: feedback implemented * updated capacitor build script with npx cap copy and removed scripts * Updates to readme and package --------- Co-authored-by: Muhammad Asad <[email protected]> Co-authored-by: Hasnainhanifse <[email protected]>

* updated contact view unit tests * updated taskfile.yml for go license check workflow task * fixed parser project error for capacitor files * fixed lint workflow by adding ignore lint checking * fixed swift package issue --------- Co-authored-by: Hasnainhanifse <[email protected]>

* updated contact view unit tests * updated taskfile.yml for go license check workflow task * fixed parser project error for capacitor files * fixed lint workflow by adding ignore lint checking * fixed swift package issue * updated lint errors for remaining files --------- Co-authored-by: Hasnainhanifse <[email protected]>

* updated contact view unit tests * updated taskfile.yml for go license check workflow task * fixed parser project error for capacitor files * fixed lint workflow by adding ignore lint checking * fixed swift package issue * updated lint errors for remaining files * updated empty commit --------- Co-authored-by: Ayush Kumar Sethi <[email protected]>

* updated contact view unit tests * updated taskfile.yml for go license check workflow task * fixed parser project error for capacitor files * fixed lint workflow by adding ignore lint checking * fixed swift package issue * updated lint errors for remaining files * updated empty commit * ensure receiver checks satisfy CodeQL intent verification --------- Co-authored-by: Hasnainhanifse <[email protected]> Co-authored-by: Hasnain Hanif <[email protected]>

* updated contact view unit tests * updated taskfile.yml for go license check workflow task * fixed parser project error for capacitor files * fixed lint workflow by adding ignore lint checking * fixed swift package issue * updated lint errors for remaining files * updated empty commit * ensure receiver checks satisfy CodeQL intent verification * added codeql comment to suppress intent verification alert * add timeout for chromium version fetching --------- Co-authored-by: Hasnainhanifse <[email protected]> Co-authored-by: Hasnain Hanif <[email protected]>

fortuna · 2026-04-07T04:30:08Z

client/capacitor/src/index.js

+window.onload = start;
+function start() {
+  getDeviceInfo().then(info => {
+    document.body.innerHTML = JSON.stringify(info, null, 4);


Why are you setting the document body? Also, setting the innerHTML is often unsafe. This is very strange.

fortuna · 2026-04-07T04:30:48Z

client/capacitor/www/mainfest.json

Duplicate with mispeled name.

Please review the code and let us know when you've done so.

fortuna · 2026-04-07T04:32:01Z

client/capacitor/package.json

+  ],
+  "scripts": {
+    "clean": "rm -rf node_modules",
+    "cap:sync:ios": "node build/cap-sync-ios.mjs",


Why are you adding this? We should be able to just use cap sync directly.

fortuna · 2026-04-07T04:32:41Z

client/capacitor/README.md

+**Debug mode:**
+
+```sh
+npm run action client/capacitor/build capacitor-ios


We should use the capacitor command line here.

fortuna · 2026-04-07T04:33:07Z

...rdova/android/OutlineAndroidLib/outline/src/main/java/org/outline/vpn/VpnServiceStarter.java

Remove Android code from this PR

fortuna · 2026-04-07T04:43:21Z

infrastructure/platforms.ts

+  return Boolean(capacitor?.isNativePlatform?.());
+}
+
+export function isCapacitorBrowserPlatform(): boolean {


This seems unused. Delete

fortuna · 2026-04-07T04:44:27Z

client/web/app/main.capacitor.ts

+import {SentryErrorReporter, Tags} from '../shared/error_reporter';
+
+const isCapacitorRuntime = isCapacitorPlatform();
+const isNativeCapacitorPlatform = isCapacitorNativePlatform();


Why do you need this? You are already in the Capacitor main

fortuna · 2026-04-07T04:45:04Z

infrastructure/platforms.ts

It's not clear to me we need this file, given we have a Capacitor-specific main. We can probably delete it.

fortuna · 2026-04-07T04:45:23Z

client/package.json

  },
  "scripts": {
-    "clean": "rm -rf output node_modules www platforms plugins",
+    "clean": "rm -rf output node_modules www platforms plugins capacitor/android/app/src/main/res/mipmap-* capacitor/android/app/src/main/res/drawable/splash.png capacitor/android/app/src/main/res/drawable*  capacitor/ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected] capacitor/ios/App/App/Assets.xcassets/Splash.imageset/Default@*",


It's not clear to me whether we should delete all the images.

fortuna · 2026-04-07T04:46:02Z

client/.gitignore

+.DS_Store
+.sourcemaps
+**/output/
+**/icons/


Not clear to me why we are ignoring the icons

jyyi1 · 2026-04-07T15:52:52Z

client/web/shared/error_reporter.ts

 // limitations under the License.

 import * as Sentry from '@sentry/browser';
+// eslint-disable-next-line n/no-extraneous-import


Why do we need to add this?

fortuna · 2026-04-07T15:53:17Z

client/web/app/outline_server_repository/vpn.capacitor.ts

Why do we need this file? It seems exactly the same as the cordova one.

fortuna · 2026-04-07T16:05:30Z

client/web/app/main.capacitor.ts

+  }
+
+  quitApplication() {
+    pluginExec<void>('quitApplication').catch((err: unknown) => {


Call CapacitorPluginOutine.quitApplication() here instead of pluginExec

fortuna · 2026-04-07T16:08:01Z

client/web/app/plugin.capacitor.ts

We shouldn't need this file. Capacitor already gives us this functionality.

fortuna · 2026-04-07T16:08:15Z

client/web/app/main.cordova.ts

fortuna · 2026-04-07T16:08:47Z

client/web/app/main.capacitor.ts

+import {CapacitorVpnApi} from './outline_server_repository/vpn.capacitor';
+import {FakeVpnApi} from './outline_server_repository/vpn.fake';
+import {OutlinePlatform} from './platform';
+import {pluginExec} from './plugin.capacitor';


We shouldn't import pluginExec. Replace with calls to CapacitorPluginOutline instead

fortuna · 2026-04-07T16:09:03Z

client/web/app/main.capacitor.ts

+    super(appVersion, dsn, tags);
+    this.hasNativeErrorReporting = Boolean(dsn && dsn.trim().length > 0);
+    if (this.hasNativeErrorReporting) {
+      pluginExec<void>('initializeErrorReporting', dsn.trim()).catch(


Call CapacitorPluginOutline directly. Same in all the other places below.

fortuna · 2026-04-07T16:10:23Z

...plugins/capacitor-plugin-outline/android/src/main/java/org/outline/CapacitorPluginOutline.kt

Let's revert the Android and iOS code in this web PR

ayush-teon and others added 30 commits July 15, 2025 20:53

Capacitor App added (#2)

3b34b38

* Capacitor App added * Updated Comments * Updated Comments * Comments addressed and updated * Splash & Icon images removed * Update README.md

Merge branch 'Jigsaw-Code:master' into master

199ef86

Merge branch 'Jigsaw-Code:master' into master

f7c1911

Merge branch 'Jigsaw-Code:master' into master

f5a23e7

Merge branch 'Jigsaw-Code:master' into master

31c6c6e

Merge branch 'Jigsaw-Code:master' into master

ee0007b

Merge branch 'Jigsaw-Code:master' into master

667382c

Merge branch 'Jigsaw-Code:master' into master

5dabba4

Merge branch 'Jigsaw-Code:master' into master

796f6fc

Merge branch 'Jigsaw-Code:master' into master

384e225

Merge branch 'Jigsaw-Code:master' into master

3983dc0

Merge branch 'Jigsaw-Code:master' into master

0fc6ce9

Merge branch 'Jigsaw-Code:master' into master

41940e2

Merge branch 'Jigsaw-Code:master' into master

5a9ec27

Merge branch 'Jigsaw-Code:master' into master

d261f20

Added go plugin

f52659e

feat: edit Go plugin for key validation

141dddf

Merge branch 'Jigsaw-Code:master' into master

a5e6be2

Merge branch 'Jigsaw-Code:master' into master

9f0c1f4

Modified readme file

1ed42d9

Merge branch 'Jigsaw-Code:master' into master

fa396a8

Removed go plugin

b2bb7fb

Modified setup to build go

3c1ea47

Modified the capacitor build script

e1e1221

Merge branch 'Jigsaw-Code:master' into master

311139e

Addressed review comment.

c4520f0

Addressed review comment

078b9d7

Merge branch 'Jigsaw-Code:master' into master

c90d95e

Addressed review comment to merge setup script to build script.

7b38988

Zahirul Islam and others added 22 commits October 22, 2025 16:33

Addressed the review comment and updated the Readme.

56b4c35

Merge pull request #5 from nthlink/nthlink/capacitor-migration-key-va…

ceb95ef

…lidation Nthlink/capacitor migration key validation

Merge branch 'Jigsaw-Code:master' into master

68c2e6f

Merge branch 'Jigsaw-Code:master' into master

7a33c9f

Merge branch 'Jigsaw-Code:master' into master

ce67048

Merge branch 'OutlineFoundation:master' into master

79cd538

Merge branch 'OutlineFoundation:master' into master

eb7db8d

fix: Assets not found issue

4869518

Merge branch 'OutlineFoundation:master' into master

d9388c2

Ntlink/capacitor upgrade (#9)

812902c

* fix: feedback implemented * updated capacitor build script with npx cap copy and removed scripts * Updates to readme and package --------- Co-authored-by: Muhammad Asad <[email protected]> Co-authored-by: Hasnainhanifse <[email protected]>

Merge branch 'OutlineFoundation:master' into master

6dcc31e

Merge branch 'OutlineFoundation:master' into master

a149b6b

Minor config updates

0b08fa2

Only Web version updates

4e6a959

ayush-teon requested a review from a team as a code owner April 6, 2026 18:21

fortuna requested changes Apr 7, 2026

View reviewed changes

jyyi1 reviewed Apr 7, 2026

View reviewed changes

fortuna requested changes Apr 7, 2026

View reviewed changes

Conversation

ayush-teon commented Apr 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants