chore(client): remove App Groups capability for app transfer#2715
Open
chore(client): remove App Groups capability for app transfer#2715
Conversation
fortuna
changed the title
There was a problem hiding this comment.
Pull request overview
This PR removes the App Groups capability from the main Outline iOS app target as a temporary measure to facilitate app transfer. The capability enables shared container access between the main app and VPN extension for log file sharing with Sentry.
Changes:
- Removed
com.apple.ApplicationGroups.iOSsystem capability from the main app target in Xcode project configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
This didn't fix the transfer issue. We use an API for app groups in two places: https://github.com/search?q=repo%3AOutlineFoundation%2Foutline-apps%20appgroup&type=code I wonder if we need to remove those API calls too. |
ohnorobo
force-pushed
the
chore/remove-app-group
branch
from
d562637 to
a4eb498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This technically breaks the attaching of the logs into the Sentry reports, but doesn't break the core functionality and we can re-attach later once we define a new app group.