fix: clarify setup hints, pin pyarrow, fix NLL error message#965
Open
Jingyuan-zhu wants to merge 1 commit intoOptimalScale:mainfrom
Open
fix: clarify setup hints, pin pyarrow, fix NLL error message#965Jingyuan-zhu wants to merge 1 commit intoOptimalScale:mainfrom
Jingyuan-zhu wants to merge 1 commit intoOptimalScale:mainfrom
Conversation
- Point datasets version hint at repo-root requirements.txt / editable install - Add pyarrow>=15.0.0 to match Hugging Face datasets 3.6.0 dependency metadata - Fix unsupported dataset type message in NLL evaluation (and add regression test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datasetsis below the minimum version, the fix hint now points users to the repository root (pip install -r requirements.txtorpip install -e .) instead of the stale pathexamples/pytorch/language-modeling/requirements.txt.pyarrow>=15.0.0to match Hugging Face datasets 3.6.0 dependency metadataf{...}text). Added_nll_unsupported_dataset_message()for a clear, testable string.