fix: crash when comparing metrics with None values#1529
Closed
mdqst wants to merge 1 commit intoOpenZeppelin:mainfrom
Closed
fix: crash when comparing metrics with None values#1529mdqst wants to merge 1 commit intoOpenZeppelin:mainfrom
mdqst wants to merge 1 commit intoOpenZeppelin:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 82 82
Lines 2272 2272
=======================================
Hits 2099 2099
Misses 173 173 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
|
In this specific scenario, files should never be None so it is actually better for the case to fail with AttributeError. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated
compare_subdictsandmarkdown_subtableto safely handle cases whereold[file]ornew[file]might beNone.using
(old.get(file) or {}).get(metric)and(new.get(file) or {}).get(metric)preventsAttributeErrorand ensures the comparison works reliably.PR Checklist