Add AccessControlDefaultAdminRulesComponent#1432
Add AccessControlDefaultAdminRulesComponent#1432ericnordelo merged 26 commits intoOpenZeppelin:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
==========================================
+ Coverage 92.99% 93.00% +0.01%
==========================================
Files 78 80 +2
Lines 2083 2230 +147
==========================================
+ Hits 1937 2074 +137
- Misses 146 156 +10
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
immrsd
left a comment
There was a problem hiding this comment.
Took a look only at the interface so far
immrsd
left a comment
There was a problem hiding this comment.
Good job, Eric! The implementation looks good, I haven't noticed any inconsistencies with our AccessControl or Solidity AccessControlDefaultAdminRules implementations. I left a couple of comments and suggestions, but overall it's for sure on the right track
|
Perfect, I will address the comments and finish the PR then with this idea. |
…eat/add-default-admin-rules-ext-#1164
Co-authored-by: immrsd <[email protected]>
…ricnordelo/cairo-contracts into feat/add-default-admin-rules-ext-#1164
…eat/add-default-admin-rules-ext-#1164
immrsd
left a comment
There was a problem hiding this comment.
Looking good! Left some comments, mostly minor ones
…ault_admin_rules.cairo Co-authored-by: immrsd <[email protected]>
…ault_admin_rules.cairo Co-authored-by: immrsd <[email protected]>
…ault_admin_rules.cairo Co-authored-by: immrsd <[email protected]>
…ault_admin_rules.cairo Co-authored-by: immrsd <[email protected]>
Co-authored-by: immrsd <[email protected]>
Co-authored-by: immrsd <[email protected]>
Co-authored-by: immrsd <[email protected]>
…ault_admin_rules.cairo Co-authored-by: immrsd <[email protected]>
Co-authored-by: immrsd <[email protected]>
Co-authored-by: immrsd <[email protected]>
Co-authored-by: immrsd <[email protected]>
…ricnordelo/cairo-contracts into feat/add-default-admin-rules-ext-#1164
Fixes #1164
PR Checklist