Skip to content

rename protocoldag_cache to protocoldag-results_cache#764

Merged
atravitz merged 1 commit intomainfrom
resume/rename_dir_for_clarity
Mar 23, 2026
Merged

rename protocoldag_cache to protocoldag-results_cache#764
atravitz merged 1 commit intomainfrom
resume/rename_dir_for_clarity

Conversation

@atravitz
Copy link
Copy Markdown
Contributor

@atravitz atravitz commented Mar 20, 2026

after testing out https://github.com/OpenFreeEnergy/openfe/1848, I think that we should rename this to make it clearer.

Tips

  • Comment "pre-commit.ci autofix" to have pre-commit.ci atomically format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

Checklist

  • Added a news entry

Developers certificate of origin

@github-actions
Copy link
Copy Markdown

No API break detected ✅

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (85711c3) to head (1e1a99f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files          42       42           
  Lines        2703     2703           
=======================================
  Hits         2673     2673           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz requested a review from IAlibay March 20, 2026 22:57
Copy link
Copy Markdown
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming change seems reasonable to me

@atravitz atravitz merged commit 95f1248 into main Mar 23, 2026
14 checks passed
@atravitz atravitz deleted the resume/rename_dir_for_clarity branch March 23, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants