Modify execute_DAG with unitresult caching#738
Conversation
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
+ Coverage 98.87% 98.89% +0.01%
==========================================
Files 42 42
Lines 2669 2703 +34
==========================================
+ Hits 2639 2673 +34
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
note: I'm taking this PR over from @IAlibay. In gufe devs meeting, we discussed needing to handle the case where a DAG A -> B -> C has a failure in B, such that both B and C are re-run. |
6b19cb9 to
4fbb80b
Compare
59d3766 to
91301e9
Compare
91301e9 to
b94e329
Compare
mikemhenry
left a comment
There was a problem hiding this comment.
LGTY! Just had some ideas on logging/testing but overall looks great!
Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
IAlibay
left a comment
There was a problem hiding this comment.
Overall it looks good, but I'm having trouble working out what the side-effect is of only popping parents from a dictionary.
|
No API break detected ✅ |
Cache a JSON of each successful ProtocolUnitResult, allowing for
execute_DAGto resume when called over a DAG that hasn't been fully executed.Checklist
newsentryDevelopers certificate of origin