Skip to content

Modify execute_DAG with unitresult caching#738

Merged
atravitz merged 32 commits intomainfrom
restart_execute
Mar 20, 2026
Merged

Modify execute_DAG with unitresult caching#738
atravitz merged 32 commits intomainfrom
restart_execute

Conversation

@IAlibay
Copy link
Copy Markdown
Member

@IAlibay IAlibay commented Feb 16, 2026

Cache a JSON of each successful ProtocolUnitResult, allowing for execute_DAG to resume when called over a DAG that hasn't been fully executed.

Checklist

  • Added a news entry

Developers certificate of origin

@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Feb 16, 2026

pre-commit.ci autofix

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (a88ba26) to head (5982414).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
+ Coverage   98.87%   98.89%   +0.01%     
==========================================
  Files          42       42              
  Lines        2669     2703      +34     
==========================================
+ Hits         2639     2673      +34     
  Misses         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread gufe/protocols/protocoldag.py Outdated
@atravitz atravitz self-assigned this Feb 16, 2026
@IAlibay IAlibay added this to the Release 1.9 milestone Feb 16, 2026
@atravitz
Copy link
Copy Markdown
Contributor

note: I'm taking this PR over from @IAlibay. In gufe devs meeting, we discussed needing to handle the case where a DAG A -> B -> C has a failure in B, such that both B and C are re-run.

@atravitz atravitz marked this pull request as draft March 11, 2026 01:52
@atravitz atravitz marked this pull request as ready for review March 11, 2026 18:17
@atravitz atravitz changed the title [WIP] Modify execute_DAG with unitresult caching Modify execute_DAG with unitresult caching Mar 11, 2026
Comment thread news/resuming.rst Outdated
Copy link
Copy Markdown
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTY! Just had some ideas on logging/testing but overall looks great!

Comment thread gufe/protocols/protocoldag.py Outdated
Comment thread gufe/protocols/protocoldag.py Outdated
Comment thread gufe/tests/test_protocoldag.py Outdated
atravitz and others added 3 commits March 12, 2026 16:42
@atravitz atravitz requested a review from mikemhenry March 13, 2026 00:04
Copy link
Copy Markdown
Member Author

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, but I'm having trouble working out what the side-effect is of only popping parents from a dictionary.

Comment thread gufe/protocols/protocoldag.py Outdated
Comment thread news/resuming.rst Outdated
Copy link
Copy Markdown
Member Author

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment thread gufe/protocols/protocoldag.py
Comment thread gufe/protocols/protocoldag.py Outdated
@atravitz atravitz enabled auto-merge (squash) March 20, 2026 18:38
@atravitz atravitz self-requested a review March 20, 2026 18:38
@github-actions
Copy link
Copy Markdown

No API break detected ✅

@atravitz atravitz merged commit 85711c3 into main Mar 20, 2026
14 checks passed
@atravitz atravitz deleted the restart_execute branch March 20, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants