[WIP DNM] Per-Unit Execution#234
Draft
dwhswenson wants to merge 22 commits intostaging-execute-dagfrom
Draft
Conversation
|
Hello @dwhswenson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-12-01 19:47:40 UTC |
…rs-in-execute-dag
Now to fix the new ones
This was referenced Dec 1, 2023
dwhswenson
changed the base branch from
shared-object-v2
to
staging-serialization
dwhswenson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as PR for better discussion with @dotsdl
Edit: This PR has been redirected so that it merges into #259. This allows you to only see the diffs specific to per-unit execution.
The original purpose of this PR (integrating with
execute_DAGhas been mainly moved into #258. As of #259, things should be enough in place that executors can update to use the new tools. The work left in this PR extends that to the draft the next generation of executors, where units can run in parallel on different machines.