Skip to content

Roshini Seelamsetty - (PRIORITY HIGH) Yagna: Hours Completed / Tasks Report – Data Accuracy Needs Review #5000

Open
roshini1212 wants to merge 2 commits intodevelopmentfrom
roshini_feat_hours_chart_percentage_label
Open

Roshini Seelamsetty - (PRIORITY HIGH) Yagna: Hours Completed / Tasks Report – Data Accuracy Needs Review #5000
roshini1212 wants to merge 2 commits intodevelopmentfrom
roshini_feat_hours_chart_percentage_label

Conversation

@roshini1212
Copy link
Copy Markdown

@roshini1212 roshini1212 commented Mar 15, 2026

Description

Screenshot 2026-03-21 at 22 06 07

Related PRS (if any):

This frontend PR is related to the backend PR (roshini_fix_hours_completed_accuracy).
OneCommunityGlobal/HGNRest#2104
To test this frontend PR you need to checkout the roshini_fix_hours_completed_accuracy backend PR.

Main changes explained:

  • Update src/components/TotalOrgSummary/HoursCompleted/HoursCompletedBarChart.jsx to use backend-provided hoursSubmittedToTasksPercentage for the header text instead of recalculating locally
  • Update src/components/TotalOrgSummary/HoursCompleted/HoursCompletedBarChart.jsx to display a dynamic distribution label below the chart showing "X% Tasks (hours) | Y% Projects (hours) (Total = 100%)" using the hoursDistributionLabel field from the API response

How to test:

  1. Check out roshini_feat_hours_chart_percentage_label branch (frontend) and roshini_fix_hours_completed_accuracy branch (backend)
  2. Run npm install then npm start for both repos
  3. Clear site data/cache
  4. Log in as Owner
  5. Go to Reports → Hours Completed (Tasks view)
  6. Set a historical date range with known data (e.g. Nov 2024 – Mar 2026)
  7. Verify the header shows a reasonable percentage (e.g. "50.0% of Total Tangible Hours Submitted to Tasks") and not thousands of %
  8. Verify the label below the chart shows "X% Tasks (hours) | Y% Projects (hours) (Total = 100%)" with percentages summing to 100%
  9. Verify the feature works correctly in dark mode

Screenshots or videos of changes:

Before:

Screenshot 2026-03-14 at 22 52 06 Screenshot 2026-03-14 at 22 52 59

After:

Screenshot 2026-03-14 at 22 31 49 Screenshot 2026-03-14 at 22 32 06 Screenshot 2026-03-14 at 22 32 56

Note:

Include the information the reviewers need to know.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 15, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit f541618
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69d80b7ca0d9b500080a67fd
😎 Deploy Preview https://deploy-preview-5000--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@roshini1212 roshini1212 changed the title Roshini - Fix Hours Completed Chart to Display Accurate Percentage and Add Hours Distribution Label Roshini Seelamsetty - Fix Hours Completed Chart to Display Accurate Percentage and Add Hours Distribution Label Mar 17, 2026
@roshini1212 roshini1212 changed the title Roshini Seelamsetty - Fix Hours Completed Chart to Display Accurate Percentage and Add Hours Distribution Label Roshini Seelamsetty - (PRIORITY HIGH) Yagna: Hours Completed / Tasks Report – Data Accuracy Needs Review Mar 22, 2026
@Anusha-Gali Anusha-Gali added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Mar 24, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roshini,

I have reviewed your PR locally and though the functionality works as per requirement below is a UI issue identified in light and dark mode.

  • As you can see the text in the bar is not visible in light mode.
  • The "X% Tasks | Y% Projects" part is not visible in dark mode and the "(Total = 100%)" goes out of the boundary.
    Issues
Image Image

Working screenshots
Image
Image
Image

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants