Sai Teja - Add backend support for dedicated pause/resume permission#2161
Open
saitejakaasoju wants to merge 5 commits intoOneCommunityGlobal:developmentfrom
Open
Sai Teja - Add backend support for dedicated pause/resume permission#2161saitejakaasoju wants to merge 5 commits intoOneCommunityGlobal:developmentfrom
saitejakaasoju wants to merge 5 commits intoOneCommunityGlobal:developmentfrom
Conversation
…s dashboard Changed logical operator from || to && in permission checks for getUserNotifications and getUnreadUserNotifications in notificationController.js. The previous condition (role !== 'Administrator' || role !== 'Owner') was always true, blocking Admins and Owners from accessing another user's notification data and causing a 'You are forbidden to access the resource' popup when viewing other dashboards or clicking a user in the Leaderboard. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…ssion logic Updated test cases for getUserNotifications and getUnreadUserNotifications to correctly reflect the fixed || to && permission check. - Updated 403 test to use a non-Admin/non-Owner role (Volunteer) - Added new tests to verify Admins and Owners can access other users' notifications Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements backend support for the dedicated pause/resume permission flow.
This PR adds support for the
interactWithPauseUserButtonpermission in backend authorization logic, adds a dedicated pause/resume route, and seeds the permission into the expected default roles.Fixes priority high bug(s):
Related PRs (if any):
This backend PR is related to the frontend PR:
sai/pause-user-permissionTo fully test this backend PR, you need to run the matching frontend PR as well.
Main changes explained:
src/routes/userProfileRouter.jsto add:PATCH /api/userProfile/:userId/pausesrc/controllers/userProfileController.jsto:pauseResumeUsercontroller logicinteractWithPauseUserButtonsrc/utilities/createInitialPermissions.jsto seedinteractWithPauseUserButtoninto:How to test:
HGNRestHighestGoodNetworkAppinteractWithPauseUserButtonScreenshots or videos of changes:
Note:
This PR should be tested together with the matching frontend PR. The frontend now uses the dedicated pause endpoint and the new permission key consistently.