Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions src/controllers/educationTaskController.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
const mongoose = require('mongoose');
const EducationTask = require('../models/educationTask');
const LessonPlan = require('../models/lessonPlan');
const UserProfile = require('../models/userProfile');
Expand Down Expand Up @@ -430,6 +431,116 @@
}
};

const getTaskSubmissions = async (req, res) => {

Check failure on line 434 in src/controllers/educationTaskController.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HGNRest&issues=AZ2euh4voBOghQxPbqMh&open=AZ2euh4voBOghQxPbqMh&pullRequest=1799
try {
const { status, studentId, lessonPlanId } = req.query;

const allowedStatuses = ['completed', 'graded'];
const statusIsValid = status && allowedStatuses.includes(status);
const studentIdIsValid = studentId && mongoose.Types.ObjectId.isValid(studentId);
const lessonPlanIdIsValid = lessonPlanId && mongoose.Types.ObjectId.isValid(lessonPlanId);

let submissions;

if (studentIdIsValid && lessonPlanIdIsValid && statusIsValid) {
submissions = await EducationTask.find({

Check failure on line 446 in src/controllers/educationTaskController.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Change this code to not construct database queries directly from user-controlled data.

See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HGNRest&issues=AZ2euh4voBOghQxPbqMl&open=AZ2euh4voBOghQxPbqMl&pullRequest=1799
status,
studentId: new mongoose.Types.ObjectId(studentId),
lessonPlanId: new mongoose.Types.ObjectId(lessonPlanId),
})
.populate('studentId', 'firstName lastName email')
.populate('lessonPlanId', 'title')
.sort({ completedAt: -1 });
} else if (studentIdIsValid && lessonPlanIdIsValid) {
submissions = await EducationTask.find({
status: { $in: ['completed', 'graded'] },
studentId: new mongoose.Types.ObjectId(studentId),
lessonPlanId: new mongoose.Types.ObjectId(lessonPlanId),
})
.populate('studentId', 'firstName lastName email')
.populate('lessonPlanId', 'title')
.sort({ completedAt: -1 });
} else if (studentIdIsValid && statusIsValid) {
submissions = await EducationTask.find({

Check failure on line 464 in src/controllers/educationTaskController.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Change this code to not construct database queries directly from user-controlled data.

See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HGNRest&issues=AZ2euh4voBOghQxPbqMj&open=AZ2euh4voBOghQxPbqMj&pullRequest=1799
status,
studentId: new mongoose.Types.ObjectId(studentId),
})
.populate('studentId', 'firstName lastName email')
.populate('lessonPlanId', 'title')
.sort({ completedAt: -1 });
} else if (lessonPlanIdIsValid && statusIsValid) {
submissions = await EducationTask.find({

Check failure on line 472 in src/controllers/educationTaskController.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Change this code to not construct database queries directly from user-controlled data.

See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HGNRest&issues=AZ2euh4voBOghQxPbqMi&open=AZ2euh4voBOghQxPbqMi&pullRequest=1799
status,
lessonPlanId: new mongoose.Types.ObjectId(lessonPlanId),
})
.populate('studentId', 'firstName lastName email')
.populate('lessonPlanId', 'title')
.sort({ completedAt: -1 });
} else if (studentIdIsValid) {
submissions = await EducationTask.find({
status: { $in: ['completed', 'graded'] },
studentId: new mongoose.Types.ObjectId(studentId),
})
.populate('studentId', 'firstName lastName email')
.populate('lessonPlanId', 'title')
.sort({ completedAt: -1 });
} else if (lessonPlanIdIsValid) {
submissions = await EducationTask.find({
status: { $in: ['completed', 'graded'] },
lessonPlanId: new mongoose.Types.ObjectId(lessonPlanId),
})
.populate('studentId', 'firstName lastName email')
.populate('lessonPlanId', 'title')
.sort({ completedAt: -1 });
} else if (statusIsValid) {
submissions = await EducationTask.find({

Check failure on line 496 in src/controllers/educationTaskController.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Change this code to not construct database queries directly from user-controlled data.

See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HGNRest&issues=AZ2euh4voBOghQxPbqMk&open=AZ2euh4voBOghQxPbqMk&pullRequest=1799
status,
})
.populate('studentId', 'firstName lastName email')
.populate('lessonPlanId', 'title')
.sort({ completedAt: -1 });
} else {
submissions = await EducationTask.find({
status: { $in: ['completed', 'graded'] },
})
.populate('studentId', 'firstName lastName email')
.populate('lessonPlanId', 'title')
.sort({ completedAt: -1 });
}

const formattedSubmissions = submissions
.map((task) => {
if (!task.studentId || !task.lessonPlanId) {
return null;
}
const lessonId = task.lessonPlanId._id.toString();
const lessonTitle = task.lessonPlanId.title || 'Unknown Lesson Plan';
return {
_id: task._id,
studentName: `${task.studentId.firstName} ${task.studentId.lastName}`,
studentEmail: task.studentId.email,
taskName: task.name || 'Unnamed Task',
taskType: task.type,
submissionLinks: task.uploadUrls,
status: task.status === 'completed' ? 'Pending Review' : 'Graded',
isLate:
task.completedAt && task.dueAt && new Date(task.completedAt) > new Date(task.dueAt),
submittedAt: task.completedAt,
assignedAt: task.assignedAt,
dueAt: task.dueAt,
grade: task.grade,
feedback: task.feedback,
lessonPlanId: lessonId,
lessonPlanTitle: lessonTitle,
};
})
.filter(Boolean);

res.status(200).json(formattedSubmissions);
} catch (error) {
res.status(500).json({ error: error.message });
}
};
return {
getEducationTasks,
getTasksByStudent,
Expand All @@ -441,6 +552,7 @@
updateTaskStatus,
gradeTask,
getTasksByStatus,
getTaskSubmissions,
markTaskAsComplete,
};
};
Expand Down
9 changes: 9 additions & 0 deletions src/models/educationTask.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ const mongoose = require('mongoose');

const educationTaskSchema = new mongoose.Schema(
{
name: {
type: String,
required: true,
trim: true,
},
lessonPlanId: {
type: mongoose.Schema.Types.ObjectId,
ref: 'LessonPlan',
Expand Down Expand Up @@ -69,5 +74,9 @@ const educationTaskSchema = new mongoose.Schema(
timestamps: true,
},
);
educationTaskSchema.index({ status: 1 });
educationTaskSchema.index({ studentId: 1 });
educationTaskSchema.index({ lessonPlanId: 1 });
educationTaskSchema.index({ completedAt: -1 });

module.exports = mongoose.model('EducationTask', educationTaskSchema);
1 change: 1 addition & 0 deletions src/models/userProfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -489,3 +489,4 @@ userProfileSchema.index({ totalTangibleHrs: 1 });
userProfileSchema.index({ bioPosted: 1 });

module.exports = mongoose.model('userProfile', userProfileSchema, 'userProfiles');
mongoose.model('User', userProfileSchema, 'userProfiles');
9 changes: 9 additions & 0 deletions src/routes/educatorRoutes.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
const express = require('express');

const router = express.Router();

const { getTaskSubmissions } = require('../controllers/educationTaskController')();

router.get('/task-submissions', getTaskSubmissions);

module.exports = router;
6 changes: 6 additions & 0 deletions src/startup/routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,9 @@ const recipeRouter = require('../routes/kitchenInventory/recipeRouter')();

const jobHitsAndApplicationsRoutes = require('../routes/jobAnalytics/JobHitsAndApplicationsRoutes');

// Education Portal
const educatorRoutes = require('../routes/educatorRoutes');

module.exports = function (app) {
app.use('/api/bm/summary-dashboard', summaryDashboardRouter);
app.use('/api', forgotPwdRouter);
Expand Down Expand Up @@ -587,6 +590,9 @@ module.exports = function (app) {
app.use('/api/lb', bidNotificationsRouter);
app.use('/api/lb', bidDeadlinesRouter);
app.use('/api/lb', SMSRouter);

// Education Portal
app.use('/api/educationportal/educator', educatorRoutes);
app.use('/api', materialCostRouter);

app.use('/api/educator/reports', studentReportRouter());
Expand Down
Loading