Reuse deposit trie root in ProcessDepositLog#16764
Open
wissyLeeei wants to merge 1 commit into
Open
Conversation
Was looking at deposit log processing and noticed `ProcessDepositLog` calls `HashTreeRoot()` twice on the same unchanged trie state — once before `InsertDeposit`, then again in the chainstart/pending branch. `getRoot` walks the tree recursively, so we pay that hash cost twice per log for no reason. Just keep the `root` from the first call and use it in both branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was looking at deposit log processing and noticed
ProcessDepositLogcallsHashTreeRoot()twice on the same unchanged trie state — once beforeInsertDeposit, then again in the chainstart/pending branch.getRootwalks the tree recursively, so we pay that hash cost twice per log for no reason. Just keep therootfrom the first call and use it in both branches.