Automates DIC boundary condition setup for multiple #375
Open
jagoosw wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
This also retains the current interface |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a possible way to streamline DIC boundary condition setup when there are multiple realisations of the carbon chemistry, e.g. the example changes:
to
This is still a bit cumbersome and it would be nice to just do:
but currently
regularize_boundary_condition(condition...)does not get the field name. I'll keep on thinking of a solution, or if that would be the preferred interface propose the change in Oceananigans.@johnryantaylor