notify contributors that signed commits are mandatory#1528
Merged
Conversation
Collaborator
Author
|
The Trivy scan is picking up some very recent CVEs, subject of pull request #1524 |
Collaborator
|
How does this work with a pull request that has unsigned commits? Are those able to be merged, or will the branch protection rule block the merge? (genuine question!) |
Collaborator
Author
|
I am fairy sure that the pull request will be blocked from merge - I hope so otherwise the singed-commits are of no use :) |
Collaborator
Author
|
the signed commits have proved to be successful, and if necessary can be bypassed by repository admins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This documents that signed commits are mandatory and notifies contributors
Description for the changelog:
document mandatory signed commits
Declaration:
Thanks for submitting a pull request, please make sure:
[e.g. GitHub CoPilot, ChatGPT, JetBrains Junie, etc][e.g. GPT-4.1, Claude Haiku 4.5, Gemini 2.5 Pro, etc][Summarize the key prompts or instructions given to the AI tools]Other info:
Closes #1525