Adjust tolarance for parallel test#7044
Open
hnil wants to merge 2 commits into
Open
Conversation
akva2
reviewed
May 11, 2026
| have_flock=0 | ||
| if command -v flock >/dev/null 2>&1 | ||
| then | ||
| have_flock=1 |
Member
There was a problem hiding this comment.
this will give very messed up diff files if tests are run in parallel. flock is available in brew, i think that is a better solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need change for clean tests on mac it seems.