use zero weights on undersaturated equations#6994
Draft
hnil wants to merge 1 commit into
Draft
Conversation
atgeirr
reviewed
Apr 24, 2026
Member
atgeirr
left a comment
atgeirr
left a comment
There was a problem hiding this comment.
Thanks! I think this should go in with the modifications requested.
| if (FluidSystem::phaseIsActive(FluidSystem::oilPhaseIdx)) { | ||
| const unsigned activeCompIdx = FluidSystem::canonicalToActiveCompIdx( | ||
| FluidSystem::solventComponentIndex(FluidSystem::oilPhaseIdx)); | ||
| if(priVars.primaryVarsMeaningGas() == PrimaryVariables::GasMeaning::Rv) { |
Member
There was a problem hiding this comment.
This is already set above, so it can be deleted.
|
|
||
| if (priVars.primaryVarsMeaningGas() == PrimaryVariables::GasMeaning::Rv | ||
| || priVars.primaryVarsMeaningGas() == PrimaryVariables::GasMeaning::Rs) { | ||
| // If only two phases are active, reset the inactive component weight. |
Member
There was a problem hiding this comment.
The comment is misleading, I think it would be better to say "If either gas or oil is undersaturated, we set the corresponding weight for that component to zero".
| if (priVars.primaryVarsMeaningGas() == PrimaryVariables::GasMeaning::Rv | ||
| || priVars.primaryVarsMeaningGas() == PrimaryVariables::GasMeaning::Rs) { | ||
| // If only two phases are active, reset the inactive component weight. | ||
| unsigned activeCompIdx = 0; |
Member
There was a problem hiding this comment.
Should be declared inside the if-statements as const unsigned activeCompIdx = ... as in lines 274, 296 etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use different weights on undersaturated equations.