Prepare SDK 1.13.1#1142
Merged
bertrand-lorentz merged 12 commits intorelease/1.13.1from Apr 4, 2025
Merged
Conversation
This only adds the new code in conditions, so it does not make the rules more restrictive for notices that do not use this new code.
YvesJo
reviewed
Feb 18, 2025
Contributor
YvesJo
left a comment
YvesJo
left a comment
There was a problem hiding this comment.
just a text update needed I think
YvesJo
previously approved these changes
Feb 18, 2025
ferrakaop
suggested changes
Mar 3, 2025
ferrakaop
left a comment
ferrakaop
left a comment
There was a problem hiding this comment.
All changes look fine for me. Please also update the legalBasis for subtype "cei" in notice-types.json.
"documentType" : "PIN",
"legalBasis" : **"32018R1046"**,
"formType" : "competition",
"type" : "pin-cfc-standard",
"description" : "Call for expressions of interest",
"subTypeId" : "CEI",
"_label" : "notice|name|CEI",
"viewTemplateIds" : [ "CEI", "summary" ]
Contributor
Author
|
Change in notice-types.json done, see added commit. |
This fixes the error due to the new Financial Regulation legal basis.
Contributor
Author
|
Added commit to use newly released SDK Analyzer 1.13.1, which handles the new value for legal basis. |
Some message templates were incorrect, so correct them and all affected rule messages.
ferrakaop
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.