feat(ui): add customizable HTML page title#437
Merged
Conversation
Adds a `customize.pageTitle` option that overrides the browser tab title (<title>) at runtime via the existing /api/v1/customize endpoint. Original title is restored on cleanup.
Coverage Report for ui
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable 'pageTitle' setting across the backend configuration and frontend API client, allowing the application title to be dynamically updated via the 'CustomizeProvider'. The review highlights a potential race condition in the 'onMount' hook where global 'document.title' side effects are performed asynchronously without verifying the component's mounted state, suggesting that this should be handled to ensure the title is correctly restored upon unmounting.
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customize.pageTitleoption that overrides the browser tab<title>(currently hardcoded toOCAP2)./api/v1/customizeendpoint andCustomizeProvider; respects thecustomize.enabledgate and restores the original title on cleanup.setting.jsonorOCAP_CUSTOMIZE_PAGETITLEenv var.Test plan
customize.enabled: trueandcustomize.pageTitle: "My Server", the browser tab showsMy Server.customize.enabled: false, the tab still shows the defaultOCAP2.customize.enabled: trueandpageTitleempty, the tab still showsOCAP2.