Skip to content

fish: 4.7.0 -> 4.7.1#517803

Closed
ddogfoodd wants to merge 8 commits intoNixOS:masterfrom
ddogfoodd:staging-nixos
Closed

fish: 4.7.0 -> 4.7.1#517803
ddogfoodd wants to merge 8 commits intoNixOS:masterfrom
ddogfoodd:staging-nixos

Conversation

@ddogfoodd
Copy link
Copy Markdown
Contributor

@ddogfoodd ddogfoodd commented May 7, 2026

Changelog: https://github.com/fish-shell/fish-shell/releases/tag/4.7.1
Diff: fish-shell/fish-shell@4.7.0...4.7.1

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 7, 2026
@cole-h
Copy link
Copy Markdown
Member

cole-h commented May 7, 2026

The 4.7.0 update went directly to master, so I think this one is probably safe to do the same? #517366

I don't mind too much, but I think most of the rebuilds are caused by needing to rebuild neovim because of tests (at least, that's what was mentioned in that prior PR).

@winterqt
Copy link
Copy Markdown
Member

winterqt commented May 7, 2026

We should probably think about skipping the fish tests for nvim.

Copy link
Copy Markdown
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's send this to master.

(Also, just fwiw, staging-nixos wouldn't be the right place for this, either.)

@ddogfoodd ddogfoodd changed the base branch from staging-nixos to master May 7, 2026 21:57
@nixpkgs-ci nixpkgs-ci Bot closed this May 7, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this May 7, 2026
@ddogfoodd ddogfoodd closed this May 7, 2026
Copy link
Copy Markdown

@nixpkgs-branch-check nixpkgs-branch-check Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR's base branch is set to master, but 7 commits from the staging-nixos branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the staging-nixos branch, change the base branch.
  • If the changes should go to the master branch, rebase your PR onto the correct merge-base:
    # git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/staging-nixos HEAD)
    git rebase --onto 2dcd9a3fb47210b2fff8350496b7c3fee7007da0 622ac2c5622e73a1f66142f81b74bea481c48c1e
    git push --force-with-lease

@ddogfoodd
Copy link
Copy Markdown
Contributor Author

Alright will re-open on master. How do I skip the nvim tests?

@nixpkgs-ci nixpkgs-ci Bot requested a review from a team May 7, 2026 22:03
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel 8.has: module (update) This PR changes an existing module in `nixos/` and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. labels May 7, 2026
@r-vdp
Copy link
Copy Markdown
Contributor

r-vdp commented May 7, 2026

You can just rebase and retarget this PR, fwiw.

You can remove the 7 extra commits with an interactive rebase.

@ddogfoodd ddogfoodd mentioned this pull request May 7, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants