fish: 4.7.0 -> 4.7.1#517803
Closed
ddogfoodd wants to merge 8 commits intoNixOS:masterfrom
Closed
Conversation
This fixes, among other things, using ty on aarch64 with a kernel with 16K or 64K pages.
Avoid creating the initrd symlink for configurations with boot.initrd.enable = false.
Member
|
The 4.7.0 update went directly to master, so I think this one is probably safe to do the same? #517366 I don't mind too much, but I think most of the rebuilds are caused by needing to rebuild neovim because of tests (at least, that's what was mentioned in that prior PR). |
Member
|
We should probably think about skipping the fish tests for nvim. |
winterqt
requested changes
May 7, 2026
There was a problem hiding this comment.
The PR's base branch is set to master, but 7 commits from the staging-nixos branch are included. Make sure you know the right base branch for your changes, then:
- If the changes should go to the
staging-nixosbranch, change the base branch. - If the changes should go to the
masterbranch, rebase your PR onto the correct merge-base:# git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/staging-nixos HEAD) git rebase --onto 2dcd9a3fb47210b2fff8350496b7c3fee7007da0 622ac2c5622e73a1f66142f81b74bea481c48c1e git push --force-with-lease
Contributor
Author
|
Alright will re-open on master. How do I skip the nvim tests? |
Contributor
|
You can just rebase and retarget this PR, fwiw. You can remove the 7 extra commits with an interactive rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/fish-shell/fish-shell/releases/tag/4.7.1
Diff: fish-shell/fish-shell@4.7.0...4.7.1
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.