COSMIC stable 1.0.12#517052
Conversation
nixpkgs-ci
Bot
added
8.has: package (update)
|
|
What with the 1.0.11 commits? |
|
thefossguy
left a comment
thefossguy
left a comment
There was a problem hiding this comment.
Please remove the 1.0.11 commits. They're not necessary. Rest looks good for the moment.
salva09
force-pushed
the
cosmic-stable-1.0.12
branch
from
3dc7be1 to
3d6c1c2
Compare
![nixpkgs-branch-check[bot]](https://avatars.githubusercontent.com/u/487568?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
salva09
force-pushed
the
cosmic-stable-1.0.12
branch
from
3d6c1c2 to
d6d3ea9
Compare
There was a problem hiding this comment.
The PR's base branch is set to master, but 1009 commits from the staging branch are included. Make sure you know the right base branch for your changes, then:
- If the changes should go to the
stagingbranch, change the base branch. - If the changes should go to the
masterbranch, rebase your PR onto the correct merge-base:# git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/staging HEAD) git rebase --onto 48a7fb14a7eeb2f838e8c3c3aa9ede3d83dddf4f 4788668746f9190acabfb293a926e7caa2d80bd1 git push --force-with-lease
salva09
force-pushed
the
cosmic-stable-1.0.12
branch
from
d6d3ea9 to
3574239
Compare
salva09
force-pushed
the
cosmic-stable-1.0.12
branch
from
3574239 to
9787156
Compare
|
I removed now the previous commits, sorry for the nixpkgs bots comments, I had a bit of trouble rebasing and dropping commits, it's my first time using git with a forked repo, hope it's all good now |
thefossguy
left a comment
thefossguy
left a comment
There was a problem hiding this comment.
Looks good! Lines up 1:1 with the changes my update script did locally.
Please switch this PR to Ready for review. Once that's done, I'll test it out and then review it.
|
Here is an overlay shared by @IceDBorn (updated for this branch) for anyone interested in using and testing the latest COSMIC version. {
nixpkgs.overlays = [
(
final: prev:
let
src = prev.fetchFromGitHub {
owner = "salva09";
repo = "nixpkgs";
rev = "9787156d30973918e9954f110a3c6b1a766cdd0e";
hash = "sha256-RRMhCsXaH/k9taYyhNPS4YjLt4GVc1vZIh5PRX1xPZU=";
};
byName = name: "${src}/pkgs/by-name/${builtins.substring 0 2 name}/${name}/package.nix";
pkgNames = [
"cosmic-applets"
"cosmic-applibrary"
"cosmic-bg"
"cosmic-comp"
"cosmic-edit"
"cosmic-files"
"cosmic-greeter"
"cosmic-icons"
"cosmic-idle"
"cosmic-initial-setup"
"cosmic-launcher"
"cosmic-notifications"
"cosmic-osd"
"cosmic-panel"
"cosmic-player"
"cosmic-randr"
"cosmic-screenshot"
"cosmic-session"
"cosmic-settings"
"cosmic-settings-daemon"
"cosmic-store"
"cosmic-term"
"cosmic-wallpapers"
"cosmic-workspaces-epoch"
"xdg-desktop-portal-cosmic"
];
in
prev.lib.genAttrs pkgNames (
name:
(final.callPackage (byName name) { }).overrideAttrs (_: {
doCheck = false;
})
)
)
];
} |
|
Packages build successfully. I'll test it out soon. Sorry about the delay :( |
|
|
thefossguy
left a comment
thefossguy
left a comment
There was a problem hiding this comment.
Built an ISO with the newly merged module and tested it out. Nothing seems broken. Thank you for working on this!
nixpkgs-ci
Bot
added
12.approvals: 1
a-kenji
left a comment
a-kenji
left a comment
There was a problem hiding this comment.
I tested ~10 binary packages manually. Looks good.
nixpkgs-ci
Bot
added
12.approvals: 2
HeitorAugustoLN
dismissed
nixpkgs-branch-check[bot]’s stale review
PR Author rebased the branch and fixed the issue
5 participants
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.