wasmer: 5.0.4 -> 7.1.0, add v8 support#516705
Conversation
nixpkgs-ci
Bot
added
8.has: package (update)
This comment was marked as outdated.
This comment was marked as outdated.
kilyanni
force-pushed
the
update/wasmer
branch
2 times, most recently
from
5c45577 to
d544d73
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
kilyanni
force-pushed
the
update/wasmer
branch
2 times, most recently
from
8463ea4 to
606c8fd
Compare
| if pc="$(WASMER_DIR="" target/release/wasmer config --pkg-config 2>/dev/null)"; then | ||
| mkdir -p "$out/lib/pkgconfig" | ||
| printf '%s\n' "$pc" > "$out/lib/pkgconfig/wasmer.pc" | ||
| fi |
There was a problem hiding this comment.
The Makefile generates pkg-config for Linux, but (for no clear reason I can discern) doesn't do so for darwin, so I manually filled that in. Not strictly necessary though I suppose
There was a problem hiding this comment.
So this is failing? What's the error?
+ lib.optionalString stdenv.hostPlatform.isDarwin ''
substituteInPlace Makefile \
--replace-fail 'install: install-wasmer install-capi-headers install-capi-lib install-pkgconfig install-misc' \
'install: install-wasmer install-capi-headers install-misc'
'';
There was a problem hiding this comment.
Ah right sorry, I misremembered
Yeah it broke
The errors are in the hidden nixpkgs-review-gha comments; here the specific one:
if pc="$(target/release/wasmer config --pkg-config 2>/dev/null)"; then
echo "$pc" | install -Dm644 /dev/stdin "/nix/store/3z902zc06hhavxrdw8hh1lkydq9l7i0m-wasmer-7.1.0"/lib/pkgconfig/wasmer.pc;
else
echo 1>&2 "WASMER_INSTALL_PREFIX was not set during build, not installing wasmer.pc";
fi
install: skipping file '/dev/stdin', as it was replaced while being copied
make: *** [Makefile:979: install-pkgconfig] Error 1
I have no idea why they do echo | install /dev/stdin ^^'
I don't have a darwin machine to debug with, so I fixed it a bit crudely maybe
2 participants
Updates wasmer to the latest version and adds support for the v8 compiler backend
Diff: wasmerio/wasmer@refs/tags/v5.0.4...refs/tags/v7.1.0
Supersedes #433805 (stale)
Closes #405782 and #403981
cc @NickCao
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.