beszel: fix testing compilation and darwin issues#513197
Open
arunoruto wants to merge 2 commits intoNixOS:masterfrom
Open
beszel: fix testing compilation and darwin issues#513197arunoruto wants to merge 2 commits intoNixOS:masterfrom
arunoruto wants to merge 2 commits intoNixOS:masterfrom
Conversation
The `testing` tag was interfering with SMART data collection in sertain scenarios according to NixOS#512864. Since the tag isn't needed, removing it should solve this problem.
Darwin doesn't support Nvidia and AMD GPU utilities, so such test should
be skipped.
While building on darwin a racing condition is happening.
To solve this, we add the following line to the
`internal/hub/systems/system.go` file:
```go
defer func() { recover() }();
```
Member
|
A friend of mine has suggested following things instead of patching the code:
|
Contributor
Author
I tried it but I am still getting: But it seems like the problem does appear upstream and should be fixed with this PR: henrygd/beszel#1951 |
BonusPlay
approved these changes
Apr 26, 2026
Member
BonusPlay
left a comment
There was a problem hiding this comment.
I guess we could merge this one (I'd just add comment on the patchPhase with link to the upstream PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testingtag introduces a problem where theinternal/hub/systems/systems_test_helpers.gofile is being compiled, which should be a moc file for testing, instead of the actual filesystems_production.go. By removing the testing tag and just adding it to thecheckFlagsvariable, this should be solved.Resolves: #510220
Darwin tries to run the GPU tests, which fails, since most of the utilities needed are not available for darwin systems (nvidia and amd). We skip those tests just for the darwin systems.
Darwin has also a weird behaviour where a racing condition is happening. To solve this, we need to introduce a small defer statement in the function which causing the racing condition.
Resolves: #512864
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.