avahi: Handle 5 security findings + 1 NixOS mitigation#508012
Merged
vcunat merged 7 commits intoNixOS:staging-nextfrom May 8, 2026
Merged
Conversation
The CVE-2024-52615 fix introduces another security issue, CVE-2025-59529. Instead CVE-2024-52615 will be mitigated via system configuration.
It would be better if there was a way to mark those mitigated issues in a way that can be machine-consumed, without causing the package to be marked insecure. In actuality, the `insecure` bit for this particular vulnerability would dpeend on the daemon configuration. The package itself cannot depend on the system configuration. A warning could be added to the NixOS module when the mitigation is disabled.
- CVE-2025-68276 / GHSA-mhf3-865v-g5rc - CVE-2025-68468 / GHSA-cp79-r4x9-vf52 - CVE-2025-68471 / GHSA-56rf-42xr-qmmg - CVE-2026-24401 / GHSA-h4vp-5m8j-f6w3 - CVE-2026-34933 / GHSA-w65r-6gxh-vhvc
This mitigates: - CVE-2024-52615 / GHSA-x6vp-f33h-h32g - CVE-2025-59529 / GHSA-73wf-3xmj-x82q (by not fixing CVE-2024-52615)
nixpkgs-ci
Bot
added
10.rebuild-linux: 501+
Jappie3
added
the
1.severity: security
Contributor
|
I don't think |
nixpkgs-ci
Bot
added
8.has: changelog
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
Co-authored-by: Sandro <[email protected]>
Member
|
I like the approach taken here, and it's surely better to take this PR as it is than doing nothing for along time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes:
Handle 5 security findings:
Add mitigations for:
The situation for CVE-2024-52615/CVE-2025-59529 is a bit confusing, but the TLDR is the latter (CVE-2025-59529) is introduced by the “fix” for CVE-2024-52615. There is a pull request for handling CVE-2025-59529, but it is not yet merged upstream, and might be incomplete.
TBD
Does this warrant a release note for a potentially breaking change?CVE-2024-52615notes should be dropped/kept?config.warnings?knownVulnerabilitiesentry?The
avahipackage can't be outright markedinsecure, which is whatknownVulnerabilitieswould do. There is no way to properly convey "this is a known vulnerability that we have mitigated" in the meta attributes.Things done
Note
stagingdue to the likelihood of 18K+ affected derivations onx86_64-linuxalone.nixos-unstable@ 68d8aa3.avahi.tests)passthru.tests. (NixOS tests onavahi.tests)Tests in lib/tests or pkgs/test for functions and "core" functionality.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.