networkmanager: 1.52.1 -> 1.54.1#446121
Closed
lesbiannix wants to merge 3 commits into
Closed
Conversation
- Add conditional NBFT (NVMe Boot Firmware Table) support via withNbft option - Enable NBFT by default when libnvme is available - Add libnvme to buildInputs when NBFT is enabled - Update hash for new version - Fixes build failure where NBFT support is required by default in 1.54.1
lesbiannix
force-pushed
the
networkmanager
branch
from
2ad8415 to
d09ff76
Compare
- Pass networking.networkmanager.nbft option to NetworkManager package - Ensures NBFT support can be controlled via NixOS configuration - Fixes missing package override for withNbft parameter
lesbiannix
force-pushed
the
networkmanager
branch
from
d09ff76 to
2e3f256
Compare
nixpkgs-ci
Bot
added
12.first-time contribution
Frontear
reviewed
Sep 25, 2025
| ''; | ||
| }; | ||
|
|
||
| nbft = mkOption { |
Member
There was a problem hiding this comment.
This doesn't hook up to cfg.package.
Also, you should mention that setting this option would force a rebuild of NetworkManager.
Member
There was a problem hiding this comment.
Yeah, this doesn't really look fleshed out. We don't have any networkmanager support in initrd, so I'm not sure where this is going.
Also people can already override the package to enable nvme support, if it turns out to be a big closure size increase and we need to keep it opt-in.
Co-authored-by: Martin Weinelt <[email protected]>
nixpkgs-ci
Bot
added
the
2.status: merge conflict
nixpkgs-ci
Bot
removed
the
12.first-time contribution
Member
|
That update was done as part of #440720 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.