Skip to content

vimgolf: migrate to by-name#405754

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
guylamar2006:migrate-vimgolf
Jun 16, 2025
Merged

vimgolf: migrate to by-name#405754
Sigmanificient merged 2 commits intoNixOS:masterfrom
guylamar2006:migrate-vimgolf

Conversation

@guylamar2006
Copy link
Copy Markdown
Contributor

@guylamar2006 guylamar2006 commented May 10, 2025

Migrate vimgolf to by-name and update gems.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 10, 2025
@guylamar2006
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 405754

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/14940658733


x86_64-linux (sandbox = true)

✅ 1 package built:
  • vimgolf

aarch64-linux (sandbox = true)

✅ 1 package built:
  • vimgolf

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • vimgolf

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • vimgolf

@liberodark
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 405754


x86_64-linux

✅ 1 package built:
  • vimgolf

Copy link
Copy Markdown
Contributor

@liberodark liberodark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sigmanificient
Copy link
Copy Markdown
Member

The app seems to work as intended, however there are some warning showing up:

Source locally installed gems is ignoring #<Bundler::StubSpecification name=rbs version=3.4.0 platform=ruby> because it is missing extensions
Source locally installed gems is ignoring #<Bundler::StubSpecification name=racc version=1.7.3 platform=ruby> because it is missing extensions
Source locally installed gems is ignoring #<Bundler::StubSpecification name=debug version=1.9.2 platform=ruby> because it is missing extensions

Is there anything that can be done about it?

@liberodark
Copy link
Copy Markdown
Contributor

Hi,

If you can remove "with lib" usage in meta ?

Best Regards

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jun 9, 2025
@Sigmanificient
Copy link
Copy Markdown
Member

Sigmanificient commented Jun 16, 2025

@liberodark Well no changes from the pr author in 2 weeks, and with lib; replacement is not a blocker

@Sigmanificient Sigmanificient merged commit 2b2b46a into NixOS:master Jun 16, 2025
43 checks passed
@guylamar2006 guylamar2006 deleted the migrate-vimgolf branch June 16, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants