nixos/kanidm: notify -> notify-reload#405726
Closed
Kranzes wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
github-actions
Bot
added
6.topic: nixos
github-actions
Bot
added
10.rebuild-darwin: 0
Contributor
|
This is only available in 1.6, correct? If so then it will either have to wait until 1.5 is retired in a month, or you’ll need to gate it on version |
Member
|
No motivation, no dice. |
adamcstephens
requested changes
May 10, 2025
Member
Author
|
Totally forgot we support multiple versions. I also assumed people know a bit about notify vs notify-reload. EDIT: I added the motivation for the change and adjusted it so it's only set for 1.6.0 and up. |
Adds systemd service reloading via the `notify-reload` service type.
Member
Author
I'm not sure, I guess not because restart is still the default change? Maybe I have to adjust some restartTriggers -> reloadTriggers, and it seems like setting ifChanged isn't recommended? I'll do that tomorrow. |
nixpkgs-ci
Bot
added
the
2.status: stale
Member
|
The feature was removed again in 1.8, so I think this PR is obsolete: kanidm/kanidm#3885 |
nixpkgs-ci
Bot
removed
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds systemd service reloading support via the
notify-reloadservice type.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.