Skip to content

networkmanager: Remove unnecessary patching out of python_path#405206

Merged
jtojnar merged 1 commit into
NixOS:masterfrom
jtojnar:nm-cleanup
May 8, 2025
Merged

networkmanager: Remove unnecessary patching out of python_path#405206
jtojnar merged 1 commit into
NixOS:masterfrom
jtojnar:nm-cleanup

Conversation

@jtojnar
Copy link
Copy Markdown
Member

@jtojnar jtojnar commented May 8, 2025

It builds without it nowadays.

Possibly thanks to https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9158f4165f748bbf2f346dee0941f28d26392bdf

Extracted out of #386514

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 8, 2025
@nix-owners nix-owners Bot requested review from domenkozar and obadz May 8, 2025 11:49
@jtojnar jtojnar merged commit dfbe6c8 into NixOS:master May 8, 2025
27 of 28 checks passed
@jtojnar jtojnar deleted the nm-cleanup branch May 8, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant