Skip to content

haproxy: add support for aws-lc#404877

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
yaxitech:haproxy-aws-lc
May 16, 2025
Merged

haproxy: add support for aws-lc#404877
Sigmanificient merged 2 commits intoNixOS:masterfrom
yaxitech:haproxy-aws-lc

Conversation

@veehaitch
Copy link
Copy Markdown
Member

Support using aws-lc as SSL library.

The NixOS test works fine when using aws-lc as sslLibrary:

{ haproxy }:
(haproxy.override { sslLibrary = "aws-lc"; }).tests.haproxy

Also remove the no longer existing USE_SYSTEMD flag: haproxy/haproxy@1584524

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 7, 2025
@nix-owners nix-owners Bot requested a review from vifino May 7, 2025 09:13
Copy link
Copy Markdown
Member

@vifino vifino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I appreciate the changes!
A few nitpicks, but no deal breaker.

Comment thread pkgs/by-name/ha/haproxy/package.nix Outdated
Comment thread pkgs/by-name/ha/haproxy/package.nix Outdated
Copy link
Copy Markdown
Member

@vifino vifino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you so much!

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels May 7, 2025
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2379

@Sigmanificient Sigmanificient merged commit be4ea44 into NixOS:master May 16, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants