Skip to content

waagent: 2.12.0.4 -> 2.13.1.1#404876

Merged
pbsds merged 2 commits intoNixOS:masterfrom
codgician:waagent-2-13-1-1
May 9, 2025
Merged

waagent: 2.12.0.4 -> 2.13.1.1#404876
pbsds merged 2 commits intoNixOS:masterfrom
codgician:waagent-2-13-1-1

Conversation

@codgician
Copy link
Copy Markdown
Member

@codgician codgician commented May 7, 2025

Things done

  • [package] Bumped waagent to 2.13.1.1
  • [module] Changed AutoUpdate.Enabled to AutoUpdate.UpdateToLatestVersion as the former one is marked as legacy according to: official FAQ. Migration is not needed because the module already takes arbitrary config value, and the former option is still being accepted by waagent.
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 7, 2025
@codgician
Copy link
Copy Markdown
Member Author

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Copy Markdown
Contributor

@codgician merge not permitted (#305350):
nixos/modules/virtualisation/waagent.nix is not in pkgs/by-name/

@pbsds
Copy link
Copy Markdown
Member

pbsds commented May 8, 2025

what happens if both Enable and UpdateToLatestVersion are set? One risk is that users have set Enable, then this PR will merge a UpdateToLatestVersion into their config as well.

@codgician
Copy link
Copy Markdown
Member Author

what happens if both Enable and UpdateToLatestVersion are set? One risk is that users have set Enable, then this PR will merge a UpdateToLatestVersion into their config as well.

Referring the example in FAQ, when AutoUpdate.Enable=y is set, the behavior would be the same regardless of AutoUpdate.UpdateToLatestVersion value for compatibility.

@pbsds
Copy link
Copy Markdown
Member

pbsds commented May 9, 2025

Man what a detailed FAQ for this exact question, thank you

@pbsds pbsds merged commit f13181e into NixOS:master May 9, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants