Skip to content

gramps: add macOS app bundle#404866

Merged
TomaSajt merged 1 commit intoNixOS:masterfrom
Enzime:gramps-bundle
May 8, 2025
Merged

gramps: add macOS app bundle#404866
TomaSajt merged 1 commit intoNixOS:masterfrom
Enzime:gramps-bundle

Conversation

@Enzime
Copy link
Copy Markdown
Member

@Enzime Enzime commented May 7, 2025 •
edited by TomaSajt
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label May 7, 2025
@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 7, 2025
@nix-owners nix-owners Bot requested review from 06kellyjac, TomaSajt and pinpox May 7, 2025 08:02
@kylerisse
Copy link
Copy Markdown
Member

kylerisse commented May 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 404866

aarch64-darwin

✅ 2 packages built:
  • gramps
  • gramps.dist

TomaSajt
TomaSajt approved these changes May 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomaSajt TomaSajt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-darwin, seems to work fine.

TomaSajt
TomaSajt reviewed May 8, 2025
View reviewed changes
Comment thread pkgs/by-name/gr/gramps/package.nix
python3Packages.mock
python3Packages.lxml
]
# TODO: use JHBuild to build the Gramps' bundle
Copy link
Copy Markdown
Contributor

@TomaSajt TomaSajt May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any instructions in the repo on how this is supposed to be done?

Copy link
Copy Markdown
Member Author

@Enzime Enzime May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could only find the JHBuild files but no instructions on how to use them:

https://github.com/gramps-project/gramps/blob/master/mac/gramps.modules

Copy link
Copy Markdown
Contributor

@TomaSajt TomaSajt May 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can find more about it on the wiki: https://gramps-project.org/wiki/index.php/Mac_OS_X:Build_from_source
https://gramps-project.org/wiki/index.php/Mac_OS_X:Build_from_source:Application_package

seems like they might be using something called gtk-osx

Copy link
Copy Markdown
Contributor

@TomaSajt TomaSajt May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, this is not in the scope of this PR.

@Enzime Enzime added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 8, 2025
@TomaSajt TomaSajt merged commit 2551c50 into NixOS:master May 8, 2025
39 checks passed
@Enzime Enzime deleted the gramps-bundle branch May 8, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomaSajt TomaSajt TomaSajt approved these changes

@pinpox pinpox Awaiting requested review from pinpox

@06kellyjac 06kellyjac Awaiting requested review from 06kellyjac

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Enzime @kylerisse @TomaSajt