Skip to content

widevine-cdm: 4.10.2830.0 -> 4.10.2891.0#404851

Merged
bjornfor merged 1 commit intoNixOS:masterfrom
fmbearmf:update-widevine
May 9, 2025
Merged

widevine-cdm: 4.10.2830.0 -> 4.10.2891.0#404851
bjornfor merged 1 commit intoNixOS:masterfrom
fmbearmf:update-widevine

Conversation

@fmbearmf
Copy link
Copy Markdown
Member

@fmbearmf fmbearmf commented May 7, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label May 7, 2025
@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 7, 2025
Copy link
Copy Markdown
Member

@phanirithvij phanirithvij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and ideally it can be automated by writing an update script and getting the last entry from https://dl.google.com/widevine-cdm/versions.txt in the script

not necessarily in this pr of course

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 7, 2025
@fmbearmf
Copy link
Copy Markdown
Member Author

fmbearmf commented May 7, 2025

yeah i was wondering why the package updating bot didnt catch it

@fmbearmf
Copy link
Copy Markdown
Member Author

fmbearmf commented May 7, 2025

anyways i'll see about it (in a different pr)

@fmbearmf
Copy link
Copy Markdown
Member Author

fmbearmf commented May 9, 2025

@kubukoz

Copy link
Copy Markdown
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (I just wrote the same patch locally, to fix Netflix :-))

@bjornfor bjornfor merged commit 5040abe into NixOS:master May 9, 2025
48 checks passed
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented May 9, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-404851-to-release-24.11 origin/release-24.11
cd .worktree/backport-404851-to-release-24.11
git switch --create backport-404851-to-release-24.11
git cherry-pick -x 5040abe52791fc093448415bf486ce353eb61a95

1 similar comment
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented May 9, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-404851-to-release-24.11 origin/release-24.11
cd .worktree/backport-404851-to-release-24.11
git switch --create backport-404851-to-release-24.11
git cherry-pick -x 5040abe52791fc093448415bf486ce353eb61a95

@bjornfor
Copy link
Copy Markdown
Contributor

bjornfor commented May 9, 2025

Manual backport PR: #405692

@fmbearmf
Copy link
Copy Markdown
Member Author

fmbearmf commented May 9, 2025

Thanks! (I just wrote the same patch locally, to fix Netflix :-))

same but prime video lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants