Skip to content

vimPlugins.famous-quotes-nvim: init at 2025-05-07#404844

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
mahyarmirrashed:master
May 7, 2025
Merged

vimPlugins.famous-quotes-nvim: init at 2025-05-07#404844
GaetanLepage merged 1 commit intoNixOS:masterfrom
mahyarmirrashed:master

Conversation

@mahyarmirrashed
Copy link
Copy Markdown
Contributor

@mahyarmirrashed mahyarmirrashed commented May 7, 2025

Things done

Add famous-quotes.nvim, a simple quote generation plugin for Neovim. You can see an example of its use here: https://github.com/mahyarmirrashed/nix-cats/blob/main/lua/zenvim/ui/alpha.lua#L58

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 6.topic: vim Advanced text editor label May 7, 2025
@mahyarmirrashed
Copy link
Copy Markdown
Contributor Author

Took advantage of a last-minute ride out to town to update nixpkgs :D

@mahyarmirrashed
Copy link
Copy Markdown
Contributor Author

I hit a rate limit trying to run nix-shell -p vimPluginsUpdater --run vim-plugins-updater. @PerchunPak can you help me with that, please?

@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 7, 2025
@GaetanLepage
Copy link
Copy Markdown
Contributor

GaetanLepage commented May 7, 2025

I hit a rate limit trying to run nix-shell -p vimPluginsUpdater --run vim-plugins-updater. @PerchunPak can you help me with that, please?

You should run

nix-shell -p vimPluginsUpdater --run vim-plugins-updater add mahyarmirrashed/famous-quotes.nvim

Otherwise the script will update the entire vimPlugins package set, which is not what you want.

Also, when you make a PR adding a new piece of software, please ensure to add some context in the PR description.
At minimum:

  • Link to the upstream project
  • A short description of what it is

Example: #402618

@mahyarmirrashed
Copy link
Copy Markdown
Contributor Author

mahyarmirrashed commented May 7, 2025

@GaetanLepage I did run that command: nix-shell -p vimPluginsUpdater --run 'vim-plugins-updater add "mahyarmirrashed/famous-quotes.nvim"'
I had found it in the documentation.
Regarding the description, sure, will do now.

@GaetanLepage
Copy link
Copy Markdown
Contributor

GaetanLepage commented May 7, 2025

@GaetanLepage I did run that command: nix-shell -p vimPluginsUpdater --run 'vim-plugins-updater add "mahyarmirrashed/famous-quotes.nvim"' I had found it in the documentation. Regarding the description, sure, will do now.

Ok good! I am also experiencing some issues on my side...

❯ vim-plugins-updater add mahyarmirrashed/famous-quotes.nvim
path is '/nix/store/3wczhikbc26yx63292m5bj8812dph7sy-dc493abfb51581b6716986b4311c367c6a100bab.tar.gz'
HTTP Error 429: Too Many Requests, Retrying in 3 seconds...
HTTP Error 429: Too Many Requests, Retrying in 3 seconds...
HTTP Error 429: Too Many Requests, Retrying in 6 seconds...
HTTP Error 429: Too Many Requests, Retrying in 6 seconds...
HTTP Error 429: Too Many Requests, Retrying in 12 seconds...
HTTP Error 429: Too Many Requests, Retrying in 12 seconds...
2 of 1664 were checked
Traceback (most recent call last):
  File "/nix/store/4i2xz1mj0p4iccgg4ycbw9kfcswrcxys-vim-plugins-updater-0.1/bin/..vim-plugins-updater-wrapped-wrapped", line 187, in <module>
    main()
  File "/nix/store/4i2xz1mj0p4iccgg4ycbw9kfcswrcxys-vim-plugins-updater-0.1/bin/..vim-plugins-updater-wrapped-wrapped", line 183, in main
    editor.run()
  File "/nix/store/xibmvar7r9228dhpgl5bbzpq5r5n26s5-pluginupdate-py/pluginupdate.py", line 691, in run
    getattr(self, command)(args)
  File "/nix/store/xibmvar7r9228dhpgl5bbzpq5r5n26s5-pluginupdate-py/pluginupdate.py", line 402, in add
    update()
  File "/nix/store/xibmvar7r9228dhpgl5bbzpq5r5n26s5-pluginupdate-py/pluginupdate.py", line 538, in update
    results = self.merge_results(current_plugins, results)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/xibmvar7r9228dhpgl5bbzpq5r5n26s5-pluginupdate-py/pluginupdate.py", line 561, in merge_results
    result[plugin.normalized_name] = (plugin_desc, plugin, redirect)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/fqm9bqqlmaqqr02qbalm1bazp810qfiw-python3-3.12.9/lib/python3.12/tempfile.py", line 494, in __getattr__
    a = getattr(file, name)
        ^^^^^^^^^^^^^^^^^^^
AttributeError: 'HTTPResponse' object has no attribute 'normalized_name'

Maybe GitHub is unstable right now.

@mahyarmirrashed
Copy link
Copy Markdown
Contributor Author

@GaetanLepage Updated description.

@mahyarmirrashed
Copy link
Copy Markdown
Contributor Author

@GaetanLepage I did run that command: nix-shell -p vimPluginsUpdater --run 'vim-plugins-updater add "mahyarmirrashed/famous-quotes.nvim"' I had found it in the documentation. Regarding the description, sure, will do now.

Ok good! I am also experiencing some issues on my side...

❯ vim-plugins-updater add mahyarmirrashed/famous-quotes.nvim
path is '/nix/store/3wczhikbc26yx63292m5bj8812dph7sy-dc493abfb51581b6716986b4311c367c6a100bab.tar.gz'
HTTP Error 429: Too Many Requests, Retrying in 3 seconds...
HTTP Error 429: Too Many Requests, Retrying in 3 seconds...
HTTP Error 429: Too Many Requests, Retrying in 6 seconds...
HTTP Error 429: Too Many Requests, Retrying in 6 seconds...
HTTP Error 429: Too Many Requests, Retrying in 12 seconds...
HTTP Error 429: Too Many Requests, Retrying in 12 seconds...
2 of 1664 were checked
Traceback (most recent call last):
  File "/nix/store/4i2xz1mj0p4iccgg4ycbw9kfcswrcxys-vim-plugins-updater-0.1/bin/..vim-plugins-updater-wrapped-wrapped", line 187, in <module>
    main()
  File "/nix/store/4i2xz1mj0p4iccgg4ycbw9kfcswrcxys-vim-plugins-updater-0.1/bin/..vim-plugins-updater-wrapped-wrapped", line 183, in main
    editor.run()
  File "/nix/store/xibmvar7r9228dhpgl5bbzpq5r5n26s5-pluginupdate-py/pluginupdate.py", line 691, in run
    getattr(self, command)(args)
  File "/nix/store/xibmvar7r9228dhpgl5bbzpq5r5n26s5-pluginupdate-py/pluginupdate.py", line 402, in add
    update()
  File "/nix/store/xibmvar7r9228dhpgl5bbzpq5r5n26s5-pluginupdate-py/pluginupdate.py", line 538, in update
    results = self.merge_results(current_plugins, results)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/xibmvar7r9228dhpgl5bbzpq5r5n26s5-pluginupdate-py/pluginupdate.py", line 561, in merge_results
    result[plugin.normalized_name] = (plugin_desc, plugin, redirect)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/fqm9bqqlmaqqr02qbalm1bazp810qfiw-python3-3.12.9/lib/python3.12/tempfile.py", line 494, in __getattr__
    a = getattr(file, name)
        ^^^^^^^^^^^^^^^^^^^
AttributeError: 'HTTPResponse' object has no attribute 'normalized_name'

Maybe GitHub is unstable right now.

Interesting, that is exactly what I was experiencing just a second ago when I tried running nix-shell -p vimPluginsUpdater --run vim-plugins-updater to generate the generated.nix...

@GaetanLepage
Copy link
Copy Markdown
Contributor

It seems to work on my side now. Please try again, otherwise I can force-push to your branch.

@mahyarmirrashed
Copy link
Copy Markdown
Contributor Author

Still failing on my side, please go ahead with a force-push.

@mahyarmirrashed
Copy link
Copy Markdown
Contributor Author

Interestingly, I still get errors even with --proc=1. Is this a script issue or a GitHub issue @GaetanLepage ?

@GaetanLepage
Copy link
Copy Markdown
Contributor

Still failing on my side, please go ahead with a force-push.

As you have not created a proper feature branch on your repo, I am not able to force-push.
Please apply the patch yourself:

diff --git a/pkgs/applications/editors/vim/plugins/generated.nix b/pkgs/applications/editors/vim/plugins/generated.nix
index 02e81e52c6b8..06f92e7ca10d 100644
--- a/pkgs/applications/editors/vim/plugins/generated.nix
+++ b/pkgs/applications/editors/vim/plugins/generated.nix
@@ -4630,6 +4630,19 @@ final: prev: {
     meta.hydraPlatforms = [ ];
   };

+  famous-quotes-nvim = buildVimPlugin {
+    pname = "famous-quotes.nvim";
+    version = "2025-05-07";
+    src = fetchFromGitHub {
+      owner = "mahyarmirrashed";
+      repo = "famous-quotes.nvim";
+      rev = "dc493abfb51581b6716986b4311c367c6a100bab";
+      sha256 = "179hgxyhzca4g0xmx02kl7gy7c6058kgww4zv7f1dvl2mf59ln67";
+    };
+    meta.homepage = "https://github.com/mahyarmirrashed/famous-quotes.nvim/";
+    meta.hydraPlatforms = [ ];
+  };
+
   far-vim = buildVimPlugin {
     pname = "far.vim";
     version = "2024-05-14";
diff --git a/pkgs/applications/editors/vim/plugins/vim-plugin-names b/pkgs/applications/editors/vim/plugins/vim-plugin-names
index 5022f66dc337..a023288461b2 100644
--- a/pkgs/applications/editors/vim/plugins/vim-plugin-names
+++ b/pkgs/applications/editors/vim/plugins/vim-plugin-names
@@ -354,6 +354,7 @@ https://github.com/sainnhe/everforest/,,
 https://github.com/google/executor.nvim/,HEAD,
 https://github.com/jinh0/eyeliner.nvim/,HEAD,
 https://github.com/fenetikm/falcon/,,
+https://github.com/mahyarmirrashed/famous-quotes.nvim/,HEAD,
 https://github.com/brooth/far.vim/,,
 https://github.com/Chaitanyabsprip/fastaction.nvim/,HEAD,
 https://github.com/pteroctopus/faster.nvim/,HEAD,

@mahyarmirrashed
Copy link
Copy Markdown
Contributor Author

mahyarmirrashed commented May 7, 2025

Still failing on my side, please go ahead with a force-push.

As you have not created a proper feature branch on your repo, I am not able to force-push. Please apply the patch yourself:

Done! Let me know if there is anything else to do @GaetanLepage :)

@GaetanLepage
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 404844 --package vimPlugins.famous-quotes-nvim


x86_64-linux

✅ 1 package built:
  • vimPlugins.famous-quotes-nvim

aarch64-linux

✅ 1 package built:
  • vimPlugins.famous-quotes-nvim

x86_64-darwin

✅ 1 package built:
  • vimPlugins.famous-quotes-nvim

aarch64-darwin

✅ 1 package built:
  • vimPlugins.famous-quotes-nvim

Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!
Let's wait for eval.

@GaetanLepage GaetanLepage merged commit caf9660 into NixOS:master May 7, 2025
25 of 28 checks passed
@mahyarmirrashed
Copy link
Copy Markdown
Contributor Author

Thanks for the help and guidance along the way, @GaetanLepage . Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants