Skip to content

hoppscotch: improve update script#404828

Merged
pbsds merged 1 commit intoNixOS:masterfrom
yzx9:hoppscotch-update-script
Jun 12, 2025
Merged

hoppscotch: improve update script#404828
pbsds merged 1 commit intoNixOS:masterfrom
yzx9:hoppscotch-update-script

Conversation

@yzx9
Copy link
Copy Markdown
Contributor

@yzx9 yzx9 commented May 7, 2025

Diff: hoppscotch/hoppscotch@2025.3.2...2025.4.0

Fix update script which was broken since the package was moved to by-name

Make the script runnable from any directory now, not only the root of nixpkgs

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 7, 2025
@nix-owners nix-owners Bot requested a review from DataHearth May 7, 2025 04:02
@yzx9
Copy link
Copy Markdown
Contributor Author

yzx9 commented May 7, 2025

@emaryn Oh, I see — I might have misunderstood that. I haven’t received the automatic update for dbeaver-bin for about a month, so I had to update it manually in #404824. I assumed the script was being run from the package directory and tried to fix it (along with two other similar scripts, this one and #404825). If it's actually run from the root of nixpkgs, then you're right — it's not really broken.

Either way, this change at least makes the script runnable from any directory now.

@yzx9 yzx9 force-pushed the hoppscotch-update-script branch from 0f8ed38 to 52985f7 Compare May 7, 2025 06:12
@yzx9 yzx9 changed the title hoppscotch: 25.3.2-0 -> 25.4.0-0, fix update script hoppscotch: 25.3.2-0 -> 25.4.0-0, improve update script May 7, 2025
@yzx9
Copy link
Copy Markdown
Contributor Author

yzx9 commented May 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 404828


x86_64-linux

✅ 1 package built:
  • hoppscotch

1 similar comment
@DataHearth
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 404828


x86_64-linux

✅ 1 package built:
  • hoppscotch

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 9, 2025
@DataHearth
Copy link
Copy Markdown
Contributor

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Copy Markdown
Contributor

@DataHearth merge not permitted (#305350):
R-Ryantm Maintainer merge: pr author is not r-ryantm
CommitterPR: pr author is not committer

Make the script runnable from any directory, not just the root of nixpkgs.
@yzx9 yzx9 force-pushed the hoppscotch-update-script branch from 52985f7 to 9865da7 Compare May 12, 2025 04:40
@yzx9 yzx9 changed the title hoppscotch: 25.3.2-0 -> 25.4.0-0, improve update script hoppscotch: improve update script May 12, 2025
@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 12, 2025
@pbsds pbsds merged commit 780f0c7 into NixOS:master Jun 12, 2025
28 checks passed
@yzx9 yzx9 deleted the hoppscotch-update-script branch June 12, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants