sddm-tokyo-night: init at 0-unstable-2023-06-13#404816
sddm-tokyo-night: init at 0-unstable-2023-06-13#404816tohmais wants to merge 2 commits intoNixOS:masterfrom
Conversation
|
Ended up having to add another commit anyways. No idea how rebasing works, but I hope it's ok. |
You’ll need to rebase your commits, but don’t worry—I can guide you through it! First steps:
Rebasing Goals
How to RebaseWe can do this in one go with an interactive rebase: git rebase -i HEAD~4This will open your configured editor with a list of the last 4 commits. In the editor:
After the rebase, you’ll need to force-push your branch: git push --forceIf you run into any issues or have questions during the process, let me know and I’ll be happy to help! |
65f77ef to
406a150
Compare
|
Committed the requested changes, and rebased. Thanks for such comprehensive instructions! |
406a150 to
d49029a
Compare
|
Fixed a missing semi-colon in the licences array. Should be good to merge now. |
d49029a to
16859b9
Compare
|
Needed to format with the new official formatter. It should finally be good to merge. |
|
Added the SDDM theme, tokyo-night-sddm, which is based on sugar dark. Edited the name slightly to be more consistent with other SDDM theme packages.
First time contributor, so please tell me if I screwed something up! Made a new PR because the original didn't follow commit guidelines.
I found using some of the other SDDM theme packages frustrating, so I'm using
propagatedUserEnvPkgsinstead ofpropagatedBuildInputsor similar. That means you install the theme by:Instead of having to add the package to both
environment.systemPackagesandservices.displayManager.sddm.extraPackages.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.