feat(perlPackages): add CPAN packages required by LedgerSMB#404421
Open
freelock wants to merge 5 commits intoNixOS:masterfrom
Open
feat(perlPackages): add CPAN packages required by LedgerSMB#404421freelock wants to merge 5 commits intoNixOS:masterfrom
freelock wants to merge 5 commits intoNixOS:masterfrom
Conversation
SigmaSquadron
requested changes
May 17, 2025
Contributor
There was a problem hiding this comment.
To recap what we discussed on matrix:
- Please review our Commit Conventions and reword/split your commits appropriately; their titles must follow very specific patterns as defined in our documentation. Don't forget to squash your intermediate/
fixupcommits.- This means that if you're adding 160 packages, we want to see 160 commits and no fixup/style/formatting commits after those.
- You're accidentally changing packages that cause mass rebuilds. Please remove your changes to
TermTableand any other dependencies that aren't related to your package additions.- Forgive our knee-jerk reaction to this, but Nixpkgs is part of the critical dependency path for several downstreams, and large, unexplained rebuilds are often the sign that something nefarious is afoot.
- You can add these mass-rebuild changes to a separate PR targeting the
stagingbranch.
- Please add your maintainer information to maintain these packages. More information is available in the Maintainers' README.
- It might be best to remove these packages from
perl-packages.nixand move them todevelopment/perl-modules, or ideallyby-name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a bunch of CPAN modules that the LedgerSMB program needs, as a first step to creating a package for it. I also updated several existing CPAN modules that could no longer be loaded because the CPAN mirrors were returning 404.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.