Skip to content

feat(perlPackages): add CPAN packages required by LedgerSMB#404421

Open
freelock wants to merge 5 commits intoNixOS:masterfrom
freelock:add-cpan-packages-for-ledgersmb
Open

feat(perlPackages): add CPAN packages required by LedgerSMB#404421
freelock wants to merge 5 commits intoNixOS:masterfrom
freelock:add-cpan-packages-for-ledgersmb

Conversation

@freelock
Copy link
Copy Markdown

@freelock freelock commented May 5, 2025

Added a bunch of CPAN modules that the LedgerSMB program needs, as a first step to creating a package for it. I also updated several existing CPAN modules that could no longer be loaded because the CPAN mirrors were returning 404.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners Bot requested review from marcusramberg, stigtsp and zakame May 5, 2025 17:25
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label May 5, 2025
@github-actions github-actions Bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 5, 2025
Copy link
Copy Markdown
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To recap what we discussed on matrix:

  1. Please review our Commit Conventions and reword/split your commits appropriately; their titles must follow very specific patterns as defined in our documentation. Don't forget to squash your intermediate/fixup commits.
    • This means that if you're adding 160 packages, we want to see 160 commits and no fixup/style/formatting commits after those.
  2. You're accidentally changing packages that cause mass rebuilds. Please remove your changes to TermTable and any other dependencies that aren't related to your package additions.
    • Forgive our knee-jerk reaction to this, but Nixpkgs is part of the critical dependency path for several downstreams, and large, unexplained rebuilds are often the sign that something nefarious is afoot.
    • You can add these mass-rebuild changes to a separate PR targeting the staging branch.
  3. Please add your maintainer information to maintain these packages. More information is available in the Maintainers' README.
  4. It might be best to remove these packages from perl-packages.nix and move them to development/perl-modules, or ideally by-name.

@SigmaSquadron SigmaSquadron added 9.needs: clean-up Somebody please clean up this mess! 9.needs: maintainer Package or module needs active maintainers 2.status: needs-changes This PR needs changes by the author labels May 17, 2025
@anoadragon453 anoadragon453 removed their request for review September 24, 2025 22:05
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: needs-changes This PR needs changes by the author 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 9.needs: clean-up Somebody please clean up this mess! 9.needs: maintainer Package or module needs active maintainers 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants