webrtc-audio-processing: 0.3 → 2.1#402787
Conversation
966a16b to
fd99520
Compare
yzx9
left a comment
There was a problem hiding this comment.
You may want to move webrtc-audio-processing/default.nix to pkgs/by-name/we/webrtc-audio-processing/package.nix,
and move 0.3.nix accordingly. Then, add a new 2.nix and update the corresponding entries in pkgs/top-level/all-packages.nix. #401089 could serve as an example.
For the merger: I’m not entirely sure why:
webrtc-audio-processing(in0.3.nix) points tov0.3.1,- and
webrtc-audio-processing_1(indefault.nix) points tov1.3.
Also, since there don’t seem to be any downstream packages. Should we rename them like this?
webrtc-audio-processing(inpackage.nix), pointing tov2.1webrtc-audio-processing_1(in1.nix), pointing tov1.3webrtc-audio-processing_0_3(in0.3.nix), pointing tov0.3.1
OK, I think this is a good way to solve it. I'll try on it.
I'm also feel puzzled about it. It seems that there is no compatibility between different major versions of |
|
In the meantime, if one of your goals is to fix webrtc-audio-processing_{0_3,1} on loongarch64-linux, you can check if patches from the following commits apply (although PRs may need to target staging):
|
fd99520 to
06328a7
Compare
|
This commit changes the "default" version from |
|
RossSmyth
left a comment
There was a problem hiding this comment.
Looks good beyond the formatting CI failure.
|
25cf5e4 to
f90c75a
Compare
a914686 to
57931d0
Compare
57931d0 to
8f1b9ba
Compare
|
We may need to contain |
|
Does Pulse not build with 2.1? |
Yes. For details, see https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/v17.0/meson.build?ref_type=tags#L730-733 |
|
And it's the only user of v1 left in tree? |
gst_all_1.gst-plugins-bad also use v1. But I haven't make sure whether it has a patch to use v2 or not. |
|
Then I guess we can keep it for now. |
Platforms are fixed and that's all I care about here :)
8f1b9ba to
aecafce
Compare
wegank
left a comment
There was a problem hiding this comment.
Built up to the graphical ISO with the PR applied on master.
Follow the upstream update.
Things done
default.nix( v1.3 ) topkgs/by-name/we/webrtc-audio-processing_1pkgs/by-name/we/webrtc-audio-processing_0_3pkgs/by-name/we/webrtc-audio-processingdinoandpipewire'swebrtc-audio-processingto the newest.Notes for the old versions:
jamiuses v0.3pulseaudioandgst_all_1.gst-plugins-baduses v1The old versions can be removed after the upstream supports the newer
webrtc-audio-processing.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.