Skip to content

dump1090: Build faup1090 for FlightAware collector#387687

Merged
jopejoe1 merged 1 commit intoNixOS:masterfrom
zhaofengli:dump1090-faup1090
Jun 11, 2025
Merged

dump1090: Build faup1090 for FlightAware collector#387687
jopejoe1 merged 1 commit intoNixOS:masterfrom
zhaofengli:dump1090-faup1090

Conversation

@zhaofengli
Copy link
Copy Markdown
Member

This PR enables building the faup1090 binary which converts dump1090 output to a format suitable for FlightAware.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 6, 2025
@nix-owners nix-owners Bot requested a review from earldouglas March 6, 2025 19:16
@aciceri
Copy link
Copy Markdown
Member

aciceri commented May 5, 2025

As #381375 has been merged (the pacakge has been renamed) there are now merge conflicts. If you resolve them I would be happy to merge this (I just became maintainer so in theory I should be able to merge with nixpkgs-merge-bot).

@zhaofengli zhaofengli force-pushed the dump1090-faup1090 branch from 0ae88c9 to baf3691 Compare May 10, 2025 03:36
@nix-owners nix-owners Bot requested a review from aciceri May 10, 2025 03:44
@aciceri
Copy link
Copy Markdown
Member

aciceri commented May 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387687


x86_64-linux

✅ 1 package built:
  • dump1090-fa

aarch64-linux

✅ 1 package built:
  • dump1090-fa

@aciceri
Copy link
Copy Markdown
Member

aciceri commented May 10, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Copy Markdown
Contributor

@aciceri merge not permitted (#305350):
CommitterPR: pr author is not committer
R-Ryantm Maintainer merge: pr author is not r-ryantm

@aciceri
Copy link
Copy Markdown
Member

aciceri commented May 10, 2025

Apparently in order to work @r-ryantm needs to the author of the PR.
I guess we'll wait that someone merges this.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 10, 2025
@jopejoe1 jopejoe1 merged commit 4675b26 into NixOS:master Jun 11, 2025
29 checks passed
@zhaofengli zhaofengli deleted the dump1090-faup1090 branch June 11, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants